Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress Selenium warnings in test log output. #5889

Merged

Conversation

Matt-Yorkley
Copy link
Contributor

Committing this spec helper suggestion from @mkllnk as agreed in Slack, so we can finally return to having usable test output when running feature specs in dev 🎉

I think this will help with the Rails 4.1 upgrade too.

@Matt-Yorkley Matt-Yorkley self-assigned this Aug 9, 2020
@luisramos0
Copy link
Contributor

👍

Copy link
Member

@mkllnk mkllnk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Matt. What do you think about an automated reminder to remove this code again?

spec/spec_helper.rb Outdated Show resolved Hide resolved
@mkllnk mkllnk merged commit a820712 into openfoodfoundation:master Aug 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants