Point better_spree_paypal_express to its latest commit #5871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🙈 I wanted this to be a draft |
|
|
|
lol thank you. That's too hidden for me 😅 |
This brings in the fix for the intermittent PayPal connection failures due to SSL verification failed. Checkout that gem's commit for details.
sauloperez
force-pushed
the
fix-paypal-ssl-error
branch
from
6879868 to
2ccb7c3
Compare
sauloperez
changed the title
luisramos0
approved these changes
Aug 7, 2020
| @@ -42,7 +42,9 @@ gem 'spree_i18n', github: 'spree/spree_i18n', branch: '1-3-stable' | |||
| # Our branch contains two changes | |||
| # - Pass customer email and phone number to PayPal (merged to upstream master) | |||
| # - Change type of password from string to password to hide it in the form | |||
| # - Skip CA cert file and use the ones provided by the OS | |||
There was a problem hiding this comment.
"Our branch contains THREE changes" :-)
Matt-Yorkley
approved these changes
Aug 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
Closes #5855
This brings in the fix for the intermittent PayPal connection failures due to SSL verification failed. Checkout that gem's commit for details.
What should we test?
Checkout an order with PayPal express payment method.
Release notes
Fix intermittently failing PayPal checkout requests due to SSL verification failed.
Changelog Category: Fixed