Bug/4592 - Hide Environment column on Payment Methods page when user is not admin #5827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luisramos0
suggested changes
Jul 27, 2020
jeduardo824
force-pushed
the
bug/remove-environment-column-when-user-is-not-super-admin
branch
2 times, most recently
from
b4a0aee to
ed9b5b6
Compare
sauloperez
reviewed
Aug 3, 2020
sauloperez
suggested changes
Aug 3, 2020
luisramos0
reviewed
Sep 4, 2020
jeduardo824
force-pushed
the
bug/remove-environment-column-when-user-is-not-super-admin
branch
from
edabfe6 to
71876ca
Compare
sauloperez
approved these changes
Sep 4, 2020
|
Hi @jeduardo824 , I checked that the Environment column was visible both as Admin (see pic below) and as Superadmin, in the Payment Methods page (/admin/payment_methods).
After staging the PR, it was observed that the Environment column was hidden from Payment Methods (pic below):
...but remained visible, when logged-in as Superadmin (pic below): All good here! 🎉 |
This was referenced May 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
Closes #4592
On the table in the Payment Methods page, we have a column "Environment" that is kind of "tech-oriented" information. This PR hides the column when the user is not an admin.
What should we test?
Check if the column "Environment" is displayed when the user is admin and hidden when it is not.
Release notes
Hide the column "Environment" from the Payment Methods page in the admin section when the user is not a super admin.
Changelog Category: Changed