Make broken spec fail reliably and set it pending #5756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The bug has been described in #5757. |
luisramos0
approved these changes
Jul 10, 2020
There was a problem hiding this comment.
Great find Maikel 👌
This means shopfront text search is not searching on variant names
I think this needs an issue on GH, I think this is at least S3, maybe S2. And it should be easy to fix.
I just confirmed this is not a v3 regression, this is broken in v2.10.2.
Matt-Yorkley
approved these changes
Jul 16, 2020
|
This needs rebasing to fix the CI error @mkllnk |
This spec has been broken for a long time, at least eight months. But it regularly passed because the search filter is applied with a delay and in that time the content matches. And once the filter is applied, no products are shown and the negative matchers pass.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
This spec has been broken for a long time, at least eight months. But it
regularly passed because the search filter is applied with a delay and
in that time the content matches. And once the filter is applied, no
products are shown and the negative matchers pass.
What should we test?
No test.
Release notes
More accurate tests.
Changelog Category: Fixed