Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky spec order_cycles/complex_updating_specific_time #5739

Merged
merged 3 commits into from
Jul 10, 2020

Conversation

Matt-Yorkley
Copy link
Contributor

What? Why?

Closes #5634

Adjusts some #expect calls to improve waiting and page interactions.

What should we test?

Less flaky build.

Release notes

Improved flaky complex_updating_specific_time_spec

@Matt-Yorkley Matt-Yorkley self-assigned this Jul 7, 2020
@Matt-Yorkley Matt-Yorkley changed the title Flaky spec complex oc Flaky spec order_cycles/complex_updating_specific_time Jul 7, 2020
Copy link
Contributor

@luisramos0 luisramos0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@Matt-Yorkley Matt-Yorkley force-pushed the flaky-spec-complex-oc branch from b587419 to e742069 Compare July 8, 2020 09:12
@Matt-Yorkley
Copy link
Contributor Author

Rebased 👍

Copy link
Member

@mkllnk mkllnk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@mkllnk mkllnk merged commit c1d7001 into openfoodfoundation:master Jul 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Flaky spec] ./spec/features/admin/order_cycles/complex_updating_specific_time_spec.rb:14
3 participants