Move all Calculators from spree to OFN and out of the Spree namespace#5613

Merged

luisramos0 merged 21 commits intoopenfoodfoundation:masterfrom luisramos0:calculators

Jul 13, 2020

+387-205

Commits on Jul 7, 2020

Bring calculators from spree_core
luisramos0
committed
Fix indentation and extract Calculator as a separate module declaration
luisramos0
committed
Merge decorators into original classes brought from spree_core
luisramos0
committed
Fix some rubocop issues
luisramos0
committed
Remove dead code related to promotions, we dont have promotions in OFN
luisramos0
committed
Move all calculators outside the spree namespace
luisramos0
committed
Move calculator specs out of the spree namespace
luisramos0
committed
Remove Spree namespace from DefaultTax
luisramos0
committed
Define DefaultTax calculator outside of spree namespace the tax_rate to be used by the app and make spree specs use calculators outside the spree namespace
luisramos0
committed
Migrate calculators to outside spree namespace
luisramos0
committed
Make migration a bit easier to read
luisramos0
committed
Extract line_items_total from compute_order
luisramos0
committed
Extract per_item_fees_total out of compute_order
luisramos0
committed
Extract per_order_fees_total out of compute_order
luisramos0
committed
Extract applicable_rate? and thus resolve rubocop complexity issue
luisramos0
committed
Early exit if max is zero to make method shorted
luisramos0
committed
Remove unnecessary variable (this sum and += come from the original
luisramos0
committed
Extract compute_for and thus resolve the rubocop complexity issue
luisramos0
committed
Fix rubucop issue in enterprise_fee model
luisramos0
committed
Convert calculators in new spec
luisramos0
committed
Fix long lines in new spec
luisramos0
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Move all Calculators from spree to OFN and out of the Spree namespace#5613

Commits on Jul 7, 2020

Bring calculators from spree_core

Fix indentation and extract Calculator as a separate module declaration

Merge decorators into original classes brought from spree_core

Fix some rubocop issues

Remove dead code related to promotions, we dont have promotions in OFN

Move all calculators outside the spree namespace

Move calculator specs out of the spree namespace

Remove Spree namespace from DefaultTax

Define DefaultTax calculator outside of spree namespace the tax_rate to be used by the app and make spree specs use calculators outside the spree namespace

Migrate calculators to outside spree namespace

Make migration a bit easier to read

Extract line_items_total from compute_order

Extract per_item_fees_total out of compute_order

Extract per_order_fees_total out of compute_order

Extract applicable_rate? and thus resolve rubocop complexity issue

Early exit if max is zero to make method shorted

Remove unnecessary variable (this sum and += come from the original

Extract compute_for and thus resolve the rubocop complexity issue

Fix rubucop issue in enterprise_fee model

Convert calculators in new spec

Fix long lines in new spec