Fix link from report to order #5593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luisramos0
approved these changes
Jun 12, 2020
|
Hey @sauloperez , Awesome - this works now. Unaware of your PR I opened an issue for this yesterday #5626 which this PR closes now. Ready to go! |
|
@sauloperez would have been great to open the link in a new tab I think :) was this discussed somewhere? |
Not it was just me fixing something that annoyed me while developing something else. I can quickly make it open on a separate tab if that's what we want. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
Fixes the link which now points to a page that doesn't exist and thus causes a slug.
I haven't found any other report rendering the order number.
What should we test?
Render any of the tax reports and click on any order number. It should lead to the order edit page.
Release notes
Fix broken order link from tax reports
Changelog Category: Fixed