[Spree 2.1] Fix Update and Calculate Fees button

[luisramos0]

What? Why?

Closes #5362

Problem with strong params where order object is not sent to the server and is not needed. Strong params validation was expecting it.

What should we test?

Verify issue is fixed.
I recommend verifying that the bug only happens with completed orders, not orders in cart.

Release notes

Changelog Category: Fixed
Fix bug in strong params implementation in admin orders controller.

[luisramos0]

Build looks good, only #5385 is broken.

[filipefurtad0]

Olá @luisramos0 ,
As you mentioned on slack, there are currently conflicts with master. Should this fix be staged for testing, or is the server already running this change in the code?

I confirm that for orders in the cart-state the Update and Recalculate Fees works as expected, and that the bug is (still) occurring only for finished orders.

[luisramos0]

I think we should block any new spree upgrade PRs (and just keep what's in staging UK as is) until the upgrade branch is not very broken.
This way you guys can continue the overall testing of the version.
After this problem of the build is fixed, all spree upgrade PRs should be staged individually and tested individually like in master: this will ensure the general testing done so far is not invalidated by some PR.

[luisramos0]

rebased to get latest 3-0-stable before testing.

[filipefurtad0]

Hi @luisramos0 ,
Feel free to stage this PR for testing.
Thank you!

[luisramos0]

ok, this is staged 👍

[filipefurtad0]

Hi @luisramos0 ,

The Update and Calculate Fees button seems to be working fine now - the issue is solved 👍

Thank you!

PS/Update: sorry - I forgot to add before, that indeed this is only verified for complete orders, and not orders in the cart.