Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dont refresh shipping rates when editing an order in the backoffice #5373

Conversation

luisramos0
Copy link
Contributor

@luisramos0 luisramos0 commented May 5, 2020

What? Why?

Closes #5367

What should we test?

Release notes

Changelog Category: Added | Changed | Deprecated | Removed | Fixed | Security

How is this related to the Spree upgrade?

Discourse thread

Dependencies

Documentation updates

@RachL
Copy link
Contributor

RachL commented May 13, 2020

@luisramos0 I guess you will close this and we can move #5367 to all the things?

@luisramos0
Copy link
Contributor Author

yes, this was a draft, and not really valid, we will need to adapt the refresh_rates process. We cant remove it otherwise new shipping methods will not be available to be selected, which would be another problem.

@luisramos0 luisramos0 closed this May 13, 2020
@luisramos0 luisramos0 deleted the dont_refresh_ship_rates_in_edit_order branch May 13, 2020 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deactivating a shipping method with fees leads to wrong delivery method and payment status in previous orders
2 participants