Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge 3-0-stable to master #5158

Merged
merged 374 commits into from
Jun 15, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
374 commits
Select commit Hold shift + click to select a range
0f726c2
Fix shipments controller after PR #4675 adapted code to rails 4 finders
luisramos0 Mar 4, 2020
cfbec2a
Fix controller specs after PR #4675 adapted code to rails 4 finders
luisramos0 Mar 5, 2020
2a010a3
Merge pull request #4919 from luisramos0/ship_ctrl
sauloperez Mar 5, 2020
4ea891e
Merge pull request #4834 from Matt-Yorkley/3-0-bind-message
sauloperez Mar 5, 2020
0815068
Merge branch 'master' into 3-0-stable-mar6
luisramos0 Mar 6, 2020
4b21aaa
Convert ActiveRecord_Associations_CollectionProxy to array so that th…
luisramos0 Mar 6, 2020
063f733
Use latest version of spree which includes PR openfoodfoundation/spre…
luisramos0 Mar 6, 2020
855d089
Adjust completed_order_with_totals to have a distributor so that logi…
luisramos0 Mar 6, 2020
e4d307f
Remove dead code related to user management
luisramos0 Mar 7, 2020
ffe814c
Adapt specs to not use anonymous user
luisramos0 Mar 7, 2020
56c29ab
Make EnterprisesController inherit from Api::BaseController to fix au…
luisramos0 Mar 7, 2020
7daa68a
Adapt consumer/shopping/orders_spec to use an order with a nil user t…
luisramos0 Mar 7, 2020
e5f05b4
Handle case where no user_ids are sent to the controller. Fixes origi…
luisramos0 Mar 7, 2020
8c367a2
Merge branch 'master' into 3-0-stable-mar6
luisramos0 Mar 9, 2020
5ce4fec
Add html to show the errors reported by devise 3 about password and p…
luisramos0 Mar 9, 2020
014e22a
Fix problem with misssing params in schedules controller and adapt it…
luisramos0 Mar 9, 2020
de2c6a8
Revert previous commits and use collection_singular_ids=(ids) setter …
luisramos0 Mar 10, 2020
5506cc8
Bypass after_rollback callback in payment
luisramos0 Mar 11, 2020
d62d89a
Fix order index search form
Matt-Yorkley Mar 12, 2020
de06eed
Merge pull request #4911 from luisramos0/3-0-manifest
sauloperez Mar 12, 2020
4b12d0b
Merge pull request #4940 from luisramos0/ent_ctrl
sauloperez Mar 12, 2020
568cba9
Merge pull request #4941 from luisramos0/devise
sauloperez Mar 12, 2020
1cba857
Merge pull request #4933 from luisramos0/ent_helper
sauloperez Mar 12, 2020
f6a1a10
Merge pull request #4955 from luisramos0/auth_fix
sauloperez Mar 12, 2020
62c35ef
Merge pull request #4953 from luisramos0/sch_fix
sauloperez Mar 12, 2020
a207c6c
Fix cart page update
Matt-Yorkley Mar 12, 2020
9a5452c
Delete test in line_items_controller_spec.rb
Matt-Yorkley Mar 12, 2020
a209b3e
Merge pull request #4980 from Matt-Yorkley/3-0-destroy-route
luisramos0 Mar 12, 2020
32a4355
Merge branch 'master' into 3-0-stable-mar6
luisramos0 Mar 12, 2020
949b6eb
Merge pull request #4982 from Matt-Yorkley/3-0-orders-form
luisramos0 Mar 12, 2020
f2089af
Merge pull request #4907 from luisramos0/3-0-enterprise_relationship
luisramos0 Mar 12, 2020
40b8eb4
Fix deprecation warning for use of #all
Matt-Yorkley Mar 12, 2020
e24d8d7
Fix deprecation warning for use of #includes without #references
Matt-Yorkley Mar 12, 2020
1cba129
Ensure line_item.variant succeeds when variant is soft-deleted
Matt-Yorkley Mar 12, 2020
b2d0154
Merge pull request #4934 from luisramos0/latest_spree_branch
sauloperez Mar 17, 2020
42d5b5d
Merge pull request #4974 from luisramos0/payment_rollback
sauloperez Mar 17, 2020
eccaaca
Merge pull request #4930 from luisramos0/3-0-stable-mar6
luisramos0 Mar 17, 2020
1c628fa
Merge branch 'master' into 3-0-stable-mar20
luisramos0 Mar 20, 2020
03cdaf5
Remove newly added attr_accessible from stripe_sca
luisramos0 Mar 20, 2020
9915717
Remove attr_accessible from paper_trail config
luisramos0 Mar 20, 2020
b33969e
Adapt to slightly different rails 4 sql data conversion
luisramos0 Mar 21, 2020
80e5608
Ensure customer selection dropdown is visible when adding customer de…
Matt-Yorkley Mar 12, 2020
337b2ab
Merge pull request #4979 from Matt-Yorkley/3-0-customer-details
luisramos0 Mar 21, 2020
86d09ff
Bring strong parameters code from spree to payment_methods_controller
luisramos0 Feb 22, 2020
38849f5
Extract method in payments_method_controller to make it readable
luisramos0 Feb 25, 2020
e5ebf45
Improve strong params implementation on payment methods controller by…
luisramos0 Feb 25, 2020
eac0da9
Fix payment method controllers by removing unnecessary param that onl…
luisramos0 Feb 25, 2020
df79934
Add missing permitted attributes to payment_methods controller
luisramos0 Mar 7, 2020
905811c
Handle strong params in admin order_cycles controller
luisramos0 Feb 23, 2020
1a46e7b
Improve strong params implementation on order_cycle controller and fi…
luisramos0 Feb 23, 2020
57f8fa2
Fix strong params in order_cycles
luisramos0 Feb 28, 2020
20c7a0d
Adapt to latest changes in order cycles controller strong params changes
luisramos0 Mar 4, 2020
fd2cf72
Extract permitted_attributes from order_cycle_controller into a speci…
luisramos0 Mar 21, 2020
5af27bb
Make checkout controller handle strong parameters
luisramos0 Feb 26, 2020
d7cccd4
Add guard clause in checkout_controller for empty params[:order]
luisramos0 Mar 2, 2020
5ae2e68
Add one more needed permitted attribute to checkout controller
luisramos0 Mar 6, 2020
1d9a6ed
Permit params in checkout controller before we adapt them to bypass i…
luisramos0 Mar 9, 2020
2c45335
Extract permitted params into a specific service
luisramos0 Mar 21, 2020
980fdd6
Replace hash rockets syntax
luisramos0 Mar 21, 2020
431076f
Add strong parameters permits to admin users_controller
luisramos0 Feb 22, 2020
d0bd281
Handle strong params on users_controller
luisramos0 Feb 23, 2020
6ed93da
Fix case with empty spree_user in user_registrations controller
luisramos0 Mar 5, 2020
aec7f12
Extract common user permitted attributes to a separate class
luisramos0 Mar 21, 2020
0ee562c
Add test coverage for PermittedAttributes::User
luisramos0 Mar 21, 2020
d7cfda8
Handle strong params in subscription_line_items controller
luisramos0 Feb 23, 2020
c3897b2
Handle strong params in subscriptions controller
luisramos0 Feb 23, 2020
58c83d0
Add missing permitted attributes to subscriptions controller
luisramos0 Mar 10, 2020
79b0867
Extract permitted attributes to separate service
luisramos0 Mar 21, 2020
c110f48
Handle strong params in spree/admin/products_controller
luisramos0 Feb 23, 2020
5b37e89
Handle strong params in variant_overrides_controller
luisramos0 Feb 23, 2020
0151b5e
Permit extra needed params in variant overrides controller
luisramos0 Feb 25, 2020
7320b38
Add missing attributes to variant override controller
luisramos0 Mar 5, 2020
a261ae1
Add missing permitted attributes to variant overrides controller
luisramos0 Mar 6, 2020
b5cdcdf
Permit specific params in products controller
luisramos0 Feb 25, 2020
36389b7
Add missing permitted attributes to bulk_product_update controller
luisramos0 Mar 2, 2020
527f6cb
Add necessary attributes to admin/products_controller and handle empt…
luisramos0 Mar 3, 2020
49a2522
Permit specific params in variants controller
luisramos0 Feb 25, 2020
58a2805
Make resource controller raise error if permitted_resource_params is …
luisramos0 Feb 25, 2020
244499a
Extract permitted atttributes to specific classes
luisramos0 Mar 21, 2020
c15433a
Bring some strong parameters code from spree to our Spree controllers
luisramos0 Feb 22, 2020
d496a4b
Add strong parameters permits to some controllers
luisramos0 Feb 22, 2020
913ea5b
Handle strong parameters in bulk_line_items controller
luisramos0 Feb 23, 2020
6bd72f4
Handle strong params in credit card controllers
luisramos0 Feb 23, 2020
e232671
Improve inventory_items_controller strong params by not using permit!
luisramos0 Feb 25, 2020
4602591
Make taxons_controller strong_params method consistent with all other…
luisramos0 Feb 25, 2020
e5a214d
Permit specific params in states controller
luisramos0 Feb 25, 2020
423d5a5
Permit specific params in taxonomies controller
luisramos0 Feb 25, 2020
b99d4ab
Permit specific params in schedules controller
luisramos0 Feb 25, 2020
9681437
Permit specific params in tax_categories controller
luisramos0 Feb 25, 2020
495c3a3
Permit specific params in images controller
luisramos0 Feb 25, 2020
d73d851
Permit specific params in tax_rates controller
luisramos0 Feb 25, 2020
6fa1ed0
Permit specific params in adjustments controller
luisramos0 Feb 25, 2020
47505b6
Permit specific params in shipping methods controller
luisramos0 Feb 25, 2020
2a426d2
Permit specific params in zones controller
luisramos0 Feb 25, 2020
8c5dfea
Fix strong params in order_cycles and schedules controllers
luisramos0 Feb 28, 2020
b7c0caf
Add needed permitted attributes to orders_controller
luisramos0 Mar 4, 2020
5a03192
Fix schedules controller permitted attributes
luisramos0 Mar 5, 2020
3ccd58d
Fix a problem in the permit list to allow a list to be taken
luisramos0 Mar 6, 2020
4e43535
Add missing permitted attribute
luisramos0 Mar 9, 2020
5e6a210
Fix problem in PermittedAttributes::User namespace
luisramos0 Mar 21, 2020
478f885
Fix problem in PermittedAttributes::Variant namespace
luisramos0 Mar 21, 2020
658a024
Re-add spring and newrelix_rpm
luisramos0 Mar 22, 2020
85f6be7
Merge pull request #5027 from luisramos0/3-0-stable-mar20
luisramos0 Mar 22, 2020
2de550e
Make OrderUpdate update all adjustments again as in v2.0.4 otherwise …
luisramos0 Mar 22, 2020
b8ed28b
Remove deface, it's already included in spree_core, it's not a direct…
luisramos0 Mar 24, 2020
5453fed
Upgrade rails from 4.0.0 to 4.0.13
luisramos0 Mar 24, 2020
89cc7ee
Upgrade devise-encryptable to 0.2.0 which is latest
luisramos0 Mar 24, 2020
570fb4b
Upgrade factory_bot_rails
luisramos0 Mar 24, 2020
c5621b7
Merge pull request #5034 from luisramos0/strong_params_payment_methods
sauloperez Mar 25, 2020
e70daf5
Merge pull request #4876 from luisramos0/strong_params_oc
sauloperez Mar 25, 2020
b323364
Merge pull request #5035 from luisramos0/strong_params_checkout
sauloperez Mar 25, 2020
d4d72c6
Merge pull request #5036 from luisramos0/strong_params_users
sauloperez Mar 25, 2020
2c487c2
Merge pull request #5037 from luisramos0/strong_params_subs
sauloperez Mar 25, 2020
a72957e
Merge pull request #4827 from luisramos0/strong_params
sauloperez Mar 25, 2020
6ba3a3c
Handle strong params in admin/enterprises_controller
luisramos0 Feb 23, 2020
34488e5
Handle strong params in enterprise_roles controller
luisramos0 Feb 23, 2020
5c179a0
Ammend strong params on enterprise controller to cover create action
luisramos0 Feb 25, 2020
29a4575
Permit specific params in enterprise_groups controller
luisramos0 Feb 25, 2020
ad9e5d9
Permit extra needed params in enterprises controller
luisramos0 Feb 25, 2020
fec5e1d
Add needed param to enterprises controller
luisramos0 Mar 12, 2020
a9a92e1
Bring some strong parameters code from spree to our Spree controllers
luisramos0 Feb 22, 2020
4fd3026
Add strong parameters permits to some controllers
luisramos0 Feb 22, 2020
9b0d7b9
Ammend customers_controller to include ship address attributes permit…
luisramos0 Feb 25, 2020
22a005d
Add needed permitted attributes to admin/customers_controller
luisramos0 Mar 7, 2020
e5f56c1
Switch to using PermittedAttributes::Address instead of spree version…
luisramos0 Mar 21, 2020
6b62c8a
Extract permitted attributes to separate service
luisramos0 Mar 21, 2020
b7cb95a
Fix problem in PermittedAttributes::Address namespace
luisramos0 Mar 21, 2020
c02a3e9
Merge pull request #5039 from luisramos0/strong_params_ent
luisramos0 Mar 25, 2020
95ba1fd
Merge pull request #5065 from luisramos0/upgrade_deps
luisramos0 Mar 25, 2020
483d847
Use `eager_load = true` in production and staging environments
Matt-Yorkley Mar 13, 2020
7bc2976
Fix logging configs for Rails 4
Matt-Yorkley Mar 13, 2020
433ae00
Ensure :info log level is set in Rails 4
Matt-Yorkley Mar 18, 2020
f1b64e9
Add comment to explain unusual fix
luisramos0 Mar 25, 2020
0cc5cbd
Merge pull request #5038 from luisramos0/strong_params_prod
Matt-Yorkley Mar 25, 2020
f70e155
Merge pull request #4984 from Matt-Yorkley/3-0-cart-route
sauloperez Mar 26, 2020
9daa40c
Merge pull request #5028 from luisramos0/remove_attr_accessible
sauloperez Mar 26, 2020
b3a4796
Merge pull request #5033 from luisramos0/ent_fees_data_types
sauloperez Mar 26, 2020
1c2815d
Merge pull request #5044 from luisramos0/add_spring
sauloperez Mar 26, 2020
a218eab
Merge pull request #4987 from Matt-Yorkley/3-0-packing
sauloperez Mar 26, 2020
0c86354
Delete dead scope in line_items
luisramos0 Mar 6, 2020
7c367da
Adapt LineItem#supplied_by_any scope to include deleted variants and …
luisramos0 Mar 6, 2020
8909238
Fix one rubocop issue
luisramos0 Mar 6, 2020
a4c7dbc
Add comment to better explain why this scope is not simply using join…
luisramos0 Mar 6, 2020
6e095bd
Fix bug in line_item_decorator, should be inner join not left outer join
luisramos0 Mar 27, 2020
80b9800
Replace SQL with equivalent AR code
luisramos0 Mar 27, 2020
154e223
Make sure test data is available before the test
luisramos0 Apr 1, 2020
384ca31
Merge branch 'master' into 3-0-stable-apr3
luisramos0 Apr 3, 2020
04986dd
Merge pull request #4932 from luisramos0/line_items_fix
luisramos0 Apr 3, 2020
b8f8db0
Merge pull request #5147 from luisramos0/3-0-stable-apr3
luisramos0 Apr 4, 2020
0726444
Add strong params implementation to properties controller
luisramos0 Apr 4, 2020
1364a5e
Merge pull request #4916 from luisramos0/adj_eli
luisramos0 Apr 4, 2020
4f08ed1
Remove commented turbo-sprockets-rails3 from Gemfile, thsi gem is not…
luisramos0 Apr 4, 2020
451cfac
Merge pull request #4995 from Matt-Yorkley/3-0-eager-load
luisramos0 Apr 4, 2020
4ceaebf
Add order.email regexp validation and add some tests for it
luisramos0 Apr 4, 2020
fa4b883
Fix timezone mix up in specs
luisramos0 Apr 4, 2020
45c0209
Merge pull request #5154 from luisramos0/prop_strong
mkllnk Apr 7, 2020
ff799b6
Avoid using update_attributes that save the order to the DB
luisramos0 Apr 7, 2020
4b23adc
Merge pull request #5157 from luisramos0/email_validation
luisramos0 Apr 9, 2020
7d82c6a
Update spre revision to a version that doesnt depend on deface, this …
luisramos0 Apr 9, 2020
7b656fa
Merge pull request #5194 from luisramos0/update_spree_rev
sauloperez Apr 16, 2020
e1c2b7e
Merge pull request #5159 from luisramos0/timezone_mixup
sauloperez Apr 16, 2020
839b373
Merge branch 'master' into 3-0-stable-Apr28
luisramos0 Apr 28, 2020
8c29797
Remove empty space on ffi line that was breaking bundle install
luisramos0 Apr 28, 2020
794fb5d
Merge pull request #5316 from luisramos0/3-0-stable-Apr28
luisramos0 Apr 28, 2020
7e12142
Collection must be after load_data so that hubs are already available…
luisramos0 Mar 2, 2020
f3e651b
present? calls length which is breaking it with error ActiveModel::Mi…
luisramos0 Apr 28, 2020
e04b18c
Merge pull request #5320 from luisramos0/vo_fix
sauloperez Apr 29, 2020
be4104d
Merge branch 'master' into 3-0-stable-may-5
luisramos0 May 5, 2020
4083da5
Add sample order to sample data
luisramos0 May 5, 2020
825f747
Add more types of sample orders
luisramos0 May 5, 2020
cb7a261
Merge pull request #5374 from luisramos0/3-0-stable-may-5
luisramos0 May 6, 2020
7804c74
Add name to permitted params and fix some rubocop issues
luisramos0 May 12, 2020
83381ad
Relax array order verification
luisramos0 May 12, 2020
be998a9
Reload shipment before shipping otherwise shipment stays as ready but…
luisramos0 May 13, 2020
1671184
Merge pull request #5375 from luisramos0/sample_order
luisramos0 May 13, 2020
19da0ba
Merge branch 'master' into 3-0-stable-may13
luisramos0 May 13, 2020
d1eebe1
Merge pull request #5426 from luisramos0/3-0-stable-may13
luisramos0 May 18, 2020
2e9f911
Add actionpack-action_caching to support action caching
luisramos0 May 19, 2020
942dde6
Merge pull request #5464 from luisramos0/3-0-action-caching
luisramos0 May 19, 2020
050e83e
Merge pull request #5410 from luisramos0/fix_some_specs
sauloperez May 21, 2020
16dfb3c
Merge pull request #5408 from luisramos0/columns_params
sauloperez May 21, 2020
04ffe7b
Fix expectations and mock responses for Rails 4
Matt-Yorkley May 22, 2020
a9abe48
Re-enable cache invalidation test
Matt-Yorkley May 22, 2020
b00fbd6
Update Fragment Caching for Rails 4
Matt-Yorkley May 22, 2020
e339a37
Allow to create order_cycle_schedules
sauloperez May 22, 2020
f0525b8
Update expectations in API caching test
Matt-Yorkley May 22, 2020
d9686d6
Enable spec files to be executed alone
sauloperez May 22, 2020
a333969
Fix and DRY specs
sauloperez May 22, 2020
ff0e85c
Merge pull request #5486 from Matt-Yorkley/3-0-caching
sauloperez May 22, 2020
f34f693
Merge branch 'master' into 3-0-stable-may-22
luisramos0 May 22, 2020
bde4acd
Update get calls in DFC controller spec
Matt-Yorkley May 26, 2020
89dd7dd
Update setting of request headers in DFC controller spec
Matt-Yorkley May 26, 2020
06b7a95
DRY duplicate subscription declaration
sauloperez May 28, 2020
9a29e63
Deal with Schedule creation in its own controller
sauloperez May 28, 2020
2203bca
Merge pull request #5489 from luisramos0/3-0-stable-may-22
luisramos0 May 28, 2020
4f63533
Fix schedule creation and subs syncing
sauloperez May 29, 2020
862364e
Fix schedule destroy spec
sauloperez May 29, 2020
f25ee8c
Extract `#editable_order_cycles`
sauloperez May 29, 2020
65c53df
Remove unnecessary callback invocations
sauloperez May 29, 2020
56b590a
Extract `#sync_subscription`
sauloperez May 29, 2020
4f3d01b
Remove unused HTML response format
sauloperez May 29, 2020
768568c
Rename @object to @schedule
sauloperez May 29, 2020
032dce1
Move OC save within success block
sauloperez May 29, 2020
815cd73
DRY specs
sauloperez May 29, 2020
8d1944d
Merge pull request #5506 from Matt-Yorkley/3-0-dfc-specs
sauloperez May 29, 2020
538c53f
Improve code readability
sauloperez May 29, 2020
24e897d
Do not build OC with schedules at the same time
sauloperez May 29, 2020
1e3bf7f
Merge pull request #5487 from coopdevs/fix-schedule-factory
Matt-Yorkley May 30, 2020
e77d9ab
Add missing strong params to less important controllers not tested in…
luisramos0 May 13, 2020
73f2844
Add spec for shipping categories
luisramos0 May 16, 2020
583b4a1
Add spec to countries_controller
luisramos0 May 16, 2020
bae1287
Add spec for return authorizations controller
luisramos0 May 16, 2020
754b657
Move controller methods to protected to keeep consitency and isolation
luisramos0 May 18, 2020
c6842ad
Add variant_unit_name to the list of fields to be ignored when creati…
luisramos0 May 13, 2020
48985bb
Use patch instead of put, because it's rails 4
luisramos0 May 7, 2020
a4a6431
Fix strong params problem where order object is not sent to controller
luisramos0 May 7, 2020
2d7f1ce
Delete all variants from test product not just the first one
luisramos0 Jun 1, 2020
8bb4310
Merge pull request #5383 from luisramos0/admin_orders_bug
luisramos0 Jun 2, 2020
c9a7a6e
Merge branch 'master' into 3-0-stable-jun-2
luisramos0 Jun 2, 2020
beb1b3f
Replay 02d46b7c518c799ad4091521652e95b3298dea93 lost in the last merg…
luisramos0 Jun 2, 2020
23b677f
Merge pull request #5388 from luisramos0/reg_proc
luisramos0 Jun 2, 2020
4438f62
Merge pull request #5421 from luisramos0/more_strong_params
luisramos0 Jun 2, 2020
5fd0a60
Merge pull request #5420 from luisramos0/pi_fix
luisramos0 Jun 2, 2020
c68459f
Make enterprises_controller_spec use api_post instead of spree_post
luisramos0 Jun 2, 2020
ff0c93a
Join module and describe declaration so that rspec picks up correct
luisramos0 Jun 2, 2020
251c04f
Make all tests in enterprises_controller_spec use api_post instead of…
luisramos0 Jun 2, 2020
f9d86eb
Join module and describe declaration so that rspec picks up correct c…
luisramos0 Jun 2, 2020
833e2ff
Merge pull request #5543 from luisramos0/product_stock
sauloperez Jun 3, 2020
8a62c8a
Merge pull request #5544 from luisramos0/api_ctrl
sauloperez Jun 3, 2020
0b76a25
Add spree_core dependencies to OFN so we can upgrade them
luisramos0 May 18, 2020
93dd61c
Merge pull request #5456 from luisramos0/3-0-stable-with-spree-deps
sauloperez Jun 3, 2020
cce26cb
Merge branch '3-0-stable' into 3-0-stable-jun-2
luisramos0 Jun 3, 2020
88896b7
Merge branch 'master' into 3-0-stable-jun-2
luisramos0 Jun 8, 2020
7924330
Fix problem with stub_const, we need auto load the controller before …
luisramos0 Jun 9, 2020
983bed3
Merge branch 'master' into 3-0-stable-jun-2
luisramos0 Jun 11, 2020
e2265dd
Fix issue in product_spec
luisramos0 Jun 11, 2020
7245a80
Merge branch 'master' into 3-0-stable-jun-2
luisramos0 Jun 12, 2020
034c3d9
Merge pull request #5548 from luisramos0/3-0-stable-jun-2
sauloperez Jun 12, 2020
86db1b6
Fix "subquery has too many columns" in reports query
Matt-Yorkley Jun 12, 2020
7287053
Merge pull request #5594 from Matt-Yorkley/3-0-reports-subquery
luisramos0 Jun 12, 2020
cf5af68
Make spec less flaky by making it wait for the Saving text to go away
luisramos0 Jun 2, 2020
f56e0ba
Mock current_spree_user to return a user without permissions so that …
luisramos0 Jun 12, 2020
6dcb2d4
Add xit, spec is still too flaky on semaphore
luisramos0 Jun 12, 2020
456f369
Fix outstanding Rubocop violations
sauloperez Jun 15, 2020
e2e3b16
Merge pull request #5549 from luisramos0/vo_flaky
sauloperez Jun 15, 2020
ea8c5d2
Comment out flaky spec
luisramos0 Jun 15, 2020
d82a1c3
Merge pull request #5602 from coopdevs/fix-style-issues
luisramos0 Jun 15, 2020
c113ee9
Merge pull request #5603 from luisramos0/xit_exchange_prods
luisramos0 Jun 15, 2020
d5bdf30
Comment out flaky variant overrides spec
luisramos0 Jun 15, 2020
62fe54d
Merge pull request #5604 from luisramos0/xit_vo_flaky_2
sauloperez Jun 15, 2020
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 1 addition & 22 deletions .rubocop_styleguide.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
# rubocop locally, the default configuration file `.rubocop.yml` loads
# our "todo lists" to ignore all current violations.
AllCops:
TargetRailsVersion: 3.2
TargetRailsVersion: 4.0
Exclude:
- 'bin/**/*'
- 'db/**/*'
Expand All @@ -20,9 +20,6 @@ AllCops:
#
# Cop settings that have been agreed upon by the OFN community

Rails:
Enabled: true

Style/Documentation:
Enabled: false

Expand Down Expand Up @@ -61,24 +58,6 @@ Lint/UselessAssignment:
Exclude:
- spec/**/*

# AFAIK, there is no good alternative to dynamic matchers until we upgrade
# to Rails 4 and can use #find_by. If there is a better approach, let's do it.
Rails/DynamicFindBy:
Enabled: false

# Same as above, #find_by is not available until Rails 4
Rails/FindBy:
Enabled: false

# Same as above, #update! is not available until Rails 4
Rails/ActiveRecordAliases:
Enabled: false

# This should be the programmer's discretion, perhaps we should review all of
# the uses of it an make specific exceptions though.
Rails/SkipsModelValidations:
Enabled: false

## Relaxed.Ruby.Style SETTINGS
#
# These styles are a starting point for the conversation around conventions
Expand Down
Loading