Do not reset the dev env when booting docker #5088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current web container's command destroys anything you might have in your local DB from a previous session, assuming you always want start from a clean environment. This is hardly the case and makes `docker-compose up` take quite long. What if you just stopped containers temporally while developing? This changes the approach to not assume anything. If you need to install a new gem or reset your DB just run the commands you would without docker. You can run anything you want with `docker-compose run web bundle exec <rails/rake command>` anyway. For someone setting things for the first time, the `Dockerfile` process still installs all dependencies.
luisramos0
approved these changes
Mar 30, 2020
Matt-Yorkley
reviewed
Apr 1, 2020
| bash -c "(bundle check || bundle install) && | ||
| wait-for-it -t 30 db:5432 && | ||
| bundle exec rake db:reset && | ||
| bundle exec rake db:test:prepare ofn:sample_data || true && |
There was a problem hiding this comment.
So the test db and sample data won't be loaded when it's first used?
Matt-Yorkley
approved these changes
Apr 1, 2020
|
this is not working for a fresh setup, we need to re-add the initial setup instructions somewhere. |
…cker Re-add setup instructions removed from docker-compose into Dockerfile…
luisramos0
approved these changes
Apr 6, 2020
Matt-Yorkley
approved these changes
Apr 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
The current web container's command destroys anything you might have in your local DB from a previous session, assuming you always want to start from a clean environment. This is hardly the case and makes
docker-compose uptake quite long. What if you just stopped containers temporally while developing? All the sample orders you created are gone 🙈This changes the approach to not assume anything. If you need to install a new gem or reset your DB just run the commands you would without docker. You can run anything you want with
docker-compose run web bundle exec <rails/rake command>anyway.For someone setting things for the first time, the
Dockerfileprocess still installs all dependencies.What should we test?
Nothing. I know it works because I always comment out these lines.
Release notes
Do not reset the development environment when starting docker
Changelog Category: Changed