Ensure perform_deliveries is correctly set in user email spec #5048
+5
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
yeah, it does fix the build in 4993. |
1 similar comment
|
yeah, it does fix the build in 4993. |
Matt-Yorkley
force-pushed
the
3-0-user-spec
branch
from
ca6e6b8 to
e27f7a4
Compare
|
Branch reset and pointed to |
|
I am merging this PR with one approval to reduce the code review lane... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5040
Wraps sending of test email in a
performing_deliveriesblock, to make sure it actually sends. The problem was thatActionMailer.Base.perfom_deliverieswas false at this point.Also checked confirmation emails are sending correctly in dev environment (with
letter_opener).Note: this issue was originally discovered in the Spree upgrade but it also affects
master, depending on the environment and order that tests are run (in parallel).Release Notes
Fixed an email issue in the test suite
Category: Fixed