[Spree 2.1] Fix authentication spec by adapting code to devise 3 #4955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…assword confirmation mismatch on user.errors[:password_confirmation] (instead of user.errors[:password])
sauloperez
approved these changes
Mar 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
Closes #4947
OFN master is on devise 2.8.8 and in rails 4 we are on devise 3.0.4.
Devise 2 reports the mismatch between password and password_confirmation on user.errors[:password] while devise 3 reports it on user.errors[:password_confirmation].
This PR adds the html template to also show user.errors[:password_confirmation].
This fixes the spec in #4947 because the error is now shown (below the password confirmation field instead of below the password field).
What should we test?
green spec