Fix problem with misssing params in schedules controller #4953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sauloperez
approved these changes
Mar 10, 2020
There was a problem hiding this comment.
Fine for me but, have you checked how the form is rendered now? could be a change in the way the form gets rendered by Rails because of what you point out regarding the association. It'd be great if we could investigate a bit more to avoid adding the hack. It can happen in a separate PR.
|
I did check the form, it works exactly the same and send exactly the same data to the server. the difference is only at the route/controller level. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
Closes #4943
This is hack to fix the problem described in #4943
I dont know the existing mechanism (working in master) that copies params like params[:name] into params[:schedule] becoming params[:schedule][:name]
My best hypothesis is that this mechanism is not working for order_cycle_ids because it is an HABTM association in Schedule and not a basic attribute or a has_many association.
What should we test?
green specs in 4943