[Spree 2.1] Fix creation of enterprises/users in specs #4821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luisramos0
force-pushed
the
3-0-stable
branch
from
5f2e7c8 to
10c6e5a
Compare
…roblem with enterprise_roles
luisramos0
force-pushed
the
3_val_issues
branch
from
b7c4880 to
5769095
Compare
luisramos0
changed the title
Matt-Yorkley
approved these changes
Feb 22, 2020
This was referenced Feb 26, 2020
…eation fixes a problem with enterprise_roles in the enterprise validation
luisramos0
force-pushed
the
3_val_issues
branch
from
5769095 to
bd02452
Compare
|
I had to change the last commit re images to use update_attributes |
sauloperez
approved these changes
Feb 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
Closes #4646
We have to move the definition of the association to after creation in the factory.
What should we test?
The error "Enterprise roles is invalid" is gone from the build.
Release notes
No release notes for upgrade isssues.