1860 Remove style from pasted text for shopfront messages #4816
Conversation
|
Good job :) |
There was a problem hiding this comment.
"I also upgraded the editor library."
ideally we should be doing these upgrades in a dependencies list.
It looks like you have upgraded textAngular, textAngular-rangy and textAngular-sanitize. From what versions did you upgrade from/to exactly? and how did you find the code for the new versions?
This upgrade means we shoul verify all places where textAngular is used, right?
I'm not sure which version we had previously. This update should come with lots of minor improvements even though we didn't have anyone complain.
Our TextAngular module supplies that code.
Yes. I didn't find a gem for it. We could start using another tool like bower but I'm not familiar with it and it's out of scope of this PR.
I have no idea from which version I upgraded. That was one of my reasons to upgrade. The commit message now contains the new version number: v1.5.16
The comment contains a link to the Github repository. I went to releases, downloaded the zip file and copied the minified files over.
Yes, I'll add that to the test list. |
There was a problem hiding this comment.
ideally we should be doing these upgrades in a dependencies list.
totally agree with @luisramos0 . The way to manage dependencies in Rails is through gems so I'd that in this case as well? I quick googling lead me to https://rubygems.org/gems/text-angular-rails/versions/1.5.16
|
gems for javascript are not always up to date and the list is naturally not so complete as if we use bower or other js package manager. |
There was a problem hiding this comment.
Nice work, @mkllnk! 🙂 I agree about not using gems for purely JS libraries, and that package management is outside the scope of this PR.
Just noting that Bower is deprecated, so maybe yarn would be good.
|
@sauloperez are you ok with this? can we move to test ready? |
|
IMO it'd be much better if we used a package manager (preferably one that takes the asset pipeline into account) but we're not making our situation worse than it was and we are fixing a bug so 👍 |
|
TESTING NOTES I pasted some green highlighted copy to a shop on AU staging (Carrot Farm) and the highlight did not display in the text field. What I did notice, however, was that it pasted in bold even though the font in the Google Doc was not bold, it was normal. So I tested this on another staging server, and it did the same thing. Thus, it's an existing bug and not a problem for this particular change. @mkllnk this change is therefore good to go 🎉 |
What? Why?
Closes #1860
When you edit the shopfront message and paste text or HTML into the editor, it preserves the formatting. It also preserved colours including backgrounds. That could lead to ugly messages. We now keep the basic formatting but remove all additional styles like colours and fonts.
Before:
After:
I also upgraded the editor library.
I did not change existing messages. Shopfront messages that already have weird formatting will keep their formatting. The solution is to go to edit the enterprise, select the whole text and click the clear formatting button, then save.
What should we test?
Check that other text fields using the same editor code work as before:
Release notes
Changed: When you edit the shopfront message and paste text, it preserves the formatting but strips additional styles like colours and fonts.
Changelog Category: Changed