Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Order Cycle Button Tooltips #4784

Merged
merged 1 commit into from
Feb 17, 2020

Conversation

blainebillings
Copy link
Contributor

What? Why?

Closes #4731

Change adds tooltips to edit, clone, and remove buttons for order cycles. While the impact is minimal, the fix helps with user experience.

What should we test?

Already tested on English and Spanish to ensure locale changes are reflected in the tooltip text. No further testing should be necessary.

Release notes

Change only requires that the icon text be added to the order_cycles/_row.html.haml file.

Changelog Category: Fixed

Copy link
Contributor

@luisramos0 luisramos0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for one more PR Blaine!

@sigmundpetersen
Copy link
Contributor

Hey @blainebillings thank you!
Did you notice that @tsara27 already had taken on this issue? Are you collaborating on it?
If not, either you or @tsara27 should pick another issue to work on 👍

@luisramos0
Copy link
Contributor

oops...
This PR is good to go, no further work is required.

Copy link
Contributor

@Matt-Yorkley Matt-Yorkley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks 👍

@RachL
Copy link
Contributor

RachL commented Feb 17, 2020

All good here! thank you @blainebillings :)

image

@luisramos0 luisramos0 merged commit 18c165e into openfoodfoundation:master Feb 17, 2020
@blainebillings blainebillings deleted the Issue4731 branch February 20, 2020 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tooltip does not appear in Order Cycles page
5 participants