-
-
Notifications
You must be signed in to change notification settings - Fork 730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mobile: shop tabs #4655
Mobile: shop tabs #4655
Conversation
2f3c712
to
3d37bbf
Compare
I'm really happy with this! :) On a side note, can we disable or ignore some of these SCSS linting rules whilst doing the mobile work? I touched / indented some existing CSS and it's demanding I rearrange all the properties in alphabetical order and giving some obtuse warnings about "depth of applicability" and nesting being "4" levels instead of "3". |
I wonder if hiding the groups tab functionality is also part of #4647? |
Nice!!! I'll review soon. I think the css rules are ok, nesting should be limited, right? I think we can ignore them if you want 👍 |
ce288d8
to
8a62cab
Compare
can you share some screenshots @Matt-Yorkley ? |
b644d4a
to
b9985ac
Compare
b9985ac
to
fd4768e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, Matt!
When creating the task, we were not thinking of Angular tabs. We thought that we would move them to their own pages. That could save some code (product reset) but your solution is much faster to browse. 👍
I left two comments which address very small style issues but I think that they are worth a couple of changes.
14d0dcb
to
6bf3e37
Compare
Thanks for the review @mkllnk, the shop helper methods and that view are much nicer now 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking good! I thought the tab HOME would be deleted...
The home tab is new, its where shopfront messages go now. Some of the UX discussion is here: #4567 (comment) |
6bf3e37
to
87caf8a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome! I left some minor comments.
I think you need to add to tests the verification of these tabs in other pages other than shopfront page: cart, checkout and on the page where you view a completed order (account) if the current shop is the shop where the order was placed (see app/views/spree/orders/show.html.haml)
…age display logic
… over the top of the floating navigtion bar
Angular controller data was being partially preserved when switching back and forth between tab templates, causing the ProductsCtrl to hold duplicate datasets when it is re-initialized after going from the shop tab to another tab, then back again.
87caf8a
to
d14d6fe
Compare
Hey @Matt-Yorkley and @mklink will the Angular tabs allow for shops to link directly to them? That was the purpose of having separate pages, I'll check if I can answer this question myself when I'm testing...let's see! |
@Matt-Yorkley testing notes for you (awesome job btw 🎉 )
Tablet with the underlined tab is correct styling ✅
|
It probably makes sense to include those 3 small bits in this PR. 👍 |
Okay, the green boxes on shopfront messages are gone, and the styling of the buttons on mobile now looks the same as on desktop. 👍 I couldn't replicate that issue with the long link going slightly off the page. It always wraps inside the box on my machine, even in mobile / tablet layout. It could be a browser-specific issue, in which case it probably wants looking at in another PR. |
Awesome news @Matt-Yorkley! I'll retest today or tomorrow.
I'll see if I can get it to replicate on other phones (will try new iPhones and Androids here in the office today). Stay tuned. |
Testing round 2:
This is good to go live! Ping @kirstenalarsen who is going to be very happy to see movement on mobile stuff again :-) |
What? Why?
Closes #4568
What should we test?
Functionality of the tabs and tab content in shopfronts. From the issue description:
Release notes
Updated shopfront tabs and content display. Product list is now a separate tab.
Changelog Category: Changed