adds missing :spree to i18n scopes #4385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luisramos0
approved these changes
Oct 21, 2019
There was a problem hiding this comment.
hello Chase!
that's it, thanks a lot for the PR!
Welcome to the community, join us on slack!
Matt-Yorkley
approved these changes
Oct 23, 2019
|
Looking good! this is ready to go
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
Closes #4304
This attempts to fix issue #4304 where translations for shipping and payment states were displayed as the default
none. The solution here is to ensure that we're scoping the translation in the yaml file correctly in thet()helper.For more, see the following in the rails guides on i18n.
https://guides.rubyonrails.org/i18n.html#how-to-store-your-custom-translations
What should we test?
Ensure that states are reflected properly.
Release notes
Fixes missing translations
Changelog Category: Fixed
How is this related to the Spree upgrade?
Possibly related since the translations are under the
spreeheadingDiscourse thread
None or Unknown
Dependencies
None.
Documentation updates
None.
Screenshots
Before
After