Shopfront pagination #4345
Merged
Shopfront pagination #4345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luisramos0
reviewed
Oct 2, 2019
app/assets/javascripts/darkswarm/services/order_cycle_resource.js.coffee
Outdated
Show resolved
Hide resolved
This PR will suddenly get a lot smaller when the ProductsRenderer PR is merged ;) |
Matt-Yorkley
force-pushed
the
shopfront_pagination
branch
2 times, most recently
from
aac4c97 to
2580157
Compare
luisramos0
reviewed
Oct 4, 2019
Matt-Yorkley
force-pushed
the
shopfront_pagination
branch
from
2580157 to
81fd887
Compare
Matt-Yorkley
force-pushed
the
shopfront_pagination
branch
4 times, most recently
from
8c3eeab to
8221e83
Compare
|
Okay, this is getting pretty close... |
Matt-Yorkley
force-pushed
the
shopfront_pagination
branch
2 times, most recently
from
a7ac735 to
30550cc
Compare
luisramos0
reviewed
Oct 4, 2019
luisramos0
reviewed
Oct 4, 2019
Matt-Yorkley
force-pushed
the
shopfront_pagination
branch
9 times, most recently
from
e90d6d3 to
f1df076
Compare
luisramos0
suggested changes
Oct 7, 2019
app/assets/javascripts/darkswarm/controllers/order_cycle_controller.js.coffee
Outdated
Show resolved
Hide resolved
app/assets/javascripts/darkswarm/controllers/products_controller.js.coffee
Outdated
Show resolved
Hide resolved
|
I would assume with the change /admin/cache_settings/ can go from super admin...? |
|
Pretty sure I removed it already..? |
|
Not from the menu ;-) |
…vice) and refactor
Matt-Yorkley
force-pushed
the
shopfront_pagination
branch
from
08346fd to
7b0c55e
Compare
Updated, double-checked, and re-staged 👍 |
|
Alright.... testing is complete. I feel like I gave it a good and proper workthrough. I'm moving this to Ready to Go..... BOOM! |
|
|
|
I'm guessing this makes a major dot release. I'm going to write a blog post in it :-D |
|
ah. good point. yes. v2.6
On Tuesday, 22 October 2019, Lynne ***@***.***> wrote:
I'm guessing this makes a major dot release. I'm going to write a blog
post in it :-D
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or unsubscribe.<
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
Closes #4040
Closes #4041
Closes #4042
Adds pagination to shop product lists and moves search and filtering server-side. Also removes the product cache...
What should we test?
Shop products should load more or less as before. Things that need testing:
Release notes
Added pagination to shop products list and removed product cache.
Changelog Category: Changed