Move CSS rule to SCSS and remove broken css file reference #4091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sauloperez
approved these changes
Jul 29, 2019
luisramos0
approved these changes
Jul 30, 2019
|
@Matt-Yorkley can you tell me the exact steps to reproduce the 404 errors? |
|
I don't see any 404 css errors in This is ready to go!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
Closes #3759
Some broken CSS references were causing 404 errors.
I've moved the CSS rule to an scss file under components (it applies to a specific jquery timepicker) and removed the broken reference causing the 404 errors.
What should we test?
404 errors should be gone.
Release notes
Fixed a missing CSS error.
Changelog Category: Fixed