Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3408 Remove feature flag for Enterprise Fee Summary #3882

Conversation

kristinalim
Copy link
Member

What? Why?

This mostly reverses/updates the changes done in #3334.

What should we test?

This is best to be tested with existing OCs (if already available) that would already have data for this report. Before testing, it would be helpful to identify hubs, producers, and coordinators that would have data needed for Step 2 below.

Each of the following roles would be checked for Steps 2 and 3.

  1. Admin
  2. Hub
  3. Producer
  4. Coordinator

To test:

  1. Check that HTML and CSV report generation work. These are using the same data objects, so except occasionally, for Steps 2 and 3 there is no need to check results for both formats - just checking one should be sufficient.
  2. Check that the "Enterprise Fee Summary" link is available in the Reports page, as described in Add link and description to /admin/reports #2656.
  3. For each user role listed above, check that these data are properly summarized:
    a. Coordinator fee for order cycle
    b. Coordinator fee for incoming exchange
    c. Coordinator fee for outgoing exchange
    d. Producer fee for incoming exchange
    e. Distributor fee for outgoing exchange
    f. Shipping fee
    g. Payment method fee
  4. Do a smoke test that the correct filter options are available to each user role.
  5. Check that orders for orders cycles to which their enterprise is not participant are not available to the user.
  6. Test that using each filter field works. (No need to do this for each user role.)

Release notes

  • Enable Enterprise Fee Summary report for non-superadmin enterprise users.

Changelog Category: Changed

@kristinalim kristinalim self-assigned this May 28, 2019
Copy link
Contributor

@luisramos0 luisramos0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool @kristinalim 👍

there's one rubocop warning you can probably fix in this PR.

Copy link
Contributor

@sauloperez sauloperez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪

@kristinalim
Copy link
Member Author

Thanks, @luisramos0 and @sauloperez!

I addressed the Rubocop issue here: 2c52c1a

Also linking to this discussion about data permissions for the report. In summary, all parties in the OC can see all fees in the OC.

Moving this to Test Ready.

@RachL RachL added pr-staged-es pr-staged-uk staging.openfoodnetwork.org.uk and removed pr-staged-es labels Jun 4, 2019
@RachL RachL self-assigned this Jun 6, 2019
@RachL
Copy link
Contributor

RachL commented Jun 6, 2019

Looking good :)

I think we are ready to go! https://docs.google.com/document/d/1UBCJWXomkrZCgV0mlJgevwdycbfFTv4A-E6ZBHw93D4/edit#

@RachL RachL removed the pr-staged-uk staging.openfoodnetwork.org.uk label Jun 6, 2019
@luisramos0 luisramos0 merged commit 568e300 into openfoodfoundation:master Jun 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enterprise Fee Summary] Enable report for non-superadmin enterprise users
4 participants