Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spree2/css #3673

Merged
merged 5 commits into from
Apr 5, 2019
Merged

Conversation

Matt-Yorkley
Copy link
Contributor

What? Why?

Closes #3577

Made a few CSS tweaks to fix some minor display issues introduced by Spree 2.

What should we test?

Take a quick look at the admin pages for Order Cycles and Inventory. And the admin menu in general.

@Matt-Yorkley
Copy link
Contributor Author

Before:
Screenshot from 2019-04-01 11-40-45

After:
Screenshot from 2019-04-01 11-40-31

Before:
Screenshot from 2019-04-01 11-43-56

After:
Screenshot from 2019-04-01 11-47-19

Before:
Screenshot from 2019-04-01 12-09-57

After:
Screenshot from 2019-04-01 12-10-13

Before:
Screenshot from 2019-04-01 12-17-14

After:
Screenshot from 2019-04-01 12-16-58

Before:
Screenshot from 2019-04-01 12-31-01

After:
Screenshot from 2019-04-01 12-30-40

@RachL RachL added pr-staged-fr staging.coopcircuits.fr and removed pr-staged-fr staging.coopcircuits.fr labels Apr 4, 2019
@RachL
Copy link
Contributor

RachL commented Apr 4, 2019

@Matt-Yorkley I've tried to stage this one but it failed

EDIT: nevermind, it's linked to staging FR

@luisramos0 luisramos0 added the pr-staged-fr staging.coopcircuits.fr label Apr 4, 2019
@RachL RachL self-assigned this Apr 4, 2019
@RachL RachL removed the pr-staged-fr staging.coopcircuits.fr label Apr 4, 2019
@RachL
Copy link
Contributor

RachL commented Apr 4, 2019

I navigated both in French and Italian, and it seems to be working good. Ready to go! A few examples:

image

image

image

@sauloperez sauloperez merged commit 1b55d04 into openfoodfoundation:2-0-stable Apr 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants