-
-
Notifications
You must be signed in to change notification settings - Fork 729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add shipping method name to orders detail report #3662
Add shipping method name to orders detail report #3662
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, welcome to OFN Steven!
Thanks for your contribution!
Added column allows users to see the shipping method of each order.
b7b8810
to
0f7ef26
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congrats! You solved an issue, improved our code style and extended our test coverage. Awesome.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome, thanks a lot!!!
I have merged this PR exceptionally because I am curious if the contributors list gets updated. @SDBowen would be contributor number 93 |
@luisramos0 Hello Luis! What can I do correctly on my end to go on the list of contributors? I was working on the branch created by @kevinchristianson perhaps that has something to do with it? I have also cloned openfoodnetwork but I had trouble bringing it up to date because of insufficient permissions. So I decided to work on the branch created by @kevinchristianson |
it's not a problem with the branch, it's the commit itself. |
@luisramos0 Thank you for pointing me to a solution. I have made the requisite changes. Perhaps, I should have mentioned earlier but my name is Usama so that is in fact me. |
yeah, I got that it was you. It's probably your local account. Good luck with that, let us know on slack if you need help. |
What? Why?
Adds a Shipping Method column to the Orders And Distributors report. This allows the users to see the the shipping detail of each order.
Closes #3446
Before:
After:
What should we test?
Generating a Orders and Distributors report will show the result of this PR.