Test inventory report to use variant overrides #3654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sauloperez
suggested changes
Mar 26, 2019
| order_cycle = create(:simple_order_cycle, suppliers: [supplier], distributors: [distributor], variants: [product.variants.first]) | ||
| create(:variant_override, hub: distributor, variant: variant, price: 2) | ||
|
|
||
| allow(subject).to receive(:params).and_return(distributor_id: distributor.id) |
There was a problem hiding this comment.
It is a bad practice to stub the subject of the test because we are then not testing the actual implementation. Do you see a way to overcome this? I guess we need to pass a different set of params instead but I haven't checked the report's implementation.
There was a problem hiding this comment.
I agree that it's bad practice. But I think fixing it is beyond this pull request.
- I used the same pattern as in the rest of the spec file. Solving this problem would be an improvement but it should be done for the whole file.
- The
paramsmethod is not provided by this controller but by one of the ancestors. Rails provides it. That's why I think it's okay to stub it. Ideally, all that filtering would happen in a service that is taking the params as input and we didn't need to stub it.
@sauloperez Are you okay to leave this as is? I don't like to get into refactoring work which then creates merge conflicts. Let's be stricter once this Spree upgrade is done.
There was a problem hiding this comment.
Fine, let's just create a tech debt issue then.
sauloperez
approved these changes
Apr 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
Closes #3237
For the Spree v2 upgrade we want to make sure that all code is using variant overrides correctly. This PR adds a couple of specs to cover the products and inventory reports.
What should we test?
Spec only changes, no tests required.
I tested the new specs with master and 2-0-stable, both passing.