Fix flaky spec by waiting for modal animation #3620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luisramos0
reviewed
Mar 19, 2019
Without waiting, `fill_in` can fail randomly: teamcapybara/capybara#1890
|
Ah, yes, the 184 spec still failed because I applied the fix only to the 210 spec. Updated the commit. Let's see if that works now. |
sauloperez
approved these changes
Mar 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
Closes #3520
Bootstrap's fading in of the customer edit modal and the webdriver's sendKeys method returning too early lead to a race condition: teamcapybara/capybara#1890
This pull request introduces waiting for the modal. If we have the same problem in other specs, we should share the waiting method.
What should we test?
No tests.
Release notes
Part of Spree upgrade.