Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump dalli from 2.7.9 to 2.7.10 #3619

Merged
merged 1 commit into from
Mar 21, 2019
Merged

Conversation

dependabot-preview[bot]
Copy link
Contributor

Bumps dalli from 2.7.9 to 2.7.10.

Changelog

Sourced from dalli's changelog.

2.7.10

  • Revert frozen string change (schneems)
  • Advertise supports_cached_versioning? in DalliStore (schneems)
  • Better detection of fork support, to allow specs to run under Truffle Ruby (deepj)
  • Update logging for over max size to log as error (aeroastro)
Commits
  • 884e1ff Merge pull request #720 from petergoldstein/release/2_7_10
  • c21c217 Prepare for 2.7.10 release
  • 32f5b8d Merge pull request #719 from petergoldstein/feature/log_over_max_size_as_error
  • 0081fb0 Log over max size as an error, rather than a warning
  • 3fb3f82 Merge pull request #718 from petergoldstein/feature/better_detection_of_fork_...
  • d37f408 Better detection of fork support
  • 6615d86 Merge pull request #717 from petergoldstein/bugfix/get_travis_build_working_a...
  • 3b5b9b9 Update patch versions
  • 6be38ab More restrictions
  • 99592a8 Restrict versions to get build working again
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot ignore this [patch|minor|major] version will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Pull request limits (per update run and/or open at any time)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

Finally, you can contact us by mentioning @dependabot.

Copy link
Contributor

@luisramos0 luisramos0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as #3403
testing as requested by Maikel: Change a product and observe the change in the shopfront.

@RachL
Copy link
Contributor

RachL commented Mar 20, 2019

Deleting a variant does not show up in the shopfront right away, you need to save changes on the product page a second time.

But I checked in production and it does not work either. So I opened #3629

Is this good to go or we need to investigate that bug @luisramos0 @mkllnk ?

https://docs.google.com/document/d/1ZHGFuqCx6Mmt6rS3aeNo8koXvIfLLOUv0peYxtzslec/edit#

@luisramos0
Copy link
Contributor

Good catch @RachL
Well, the problem looks related to cache and dalli is related to cache but if you say you can replicate it in prod, I'd merge this PR and investigate the problem in the new issue.

@mkllnk
Copy link
Member

mkllnk commented Mar 21, 2019

I think this is ready to go then. Merging...

@mkllnk mkllnk merged commit 130ba64 into master Mar 21, 2019
@mkllnk mkllnk deleted the dependabot/bundler/dalli-2.7.10 branch March 21, 2019 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants