[Spree Upgrade] Make Bulk Invoices part of spree upgrade phase 2 #3471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luisramos0
force-pushed
the
2-0-bulk-invoices-phase2
branch
from
ee0b668 to
935c8cb
Compare
sauloperez
approved these changes
Feb 12, 2019
|
thank you @kristinalim :-D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
Move broken bulk invoices test to xdescribe in 2-0-stable branch so we can focus on core features first.
I have moved #3427 under phase 2 epic #2953
Product Import quick fix
I am using this PR to move ProductImporter spec back to xdescribe. It was moved to describe by mistake here as there's still one broken test in this spec that will be fixed as part of #2783, we can then remove the xdescribe.
What should we test?
spec should not be broken is this build (I have verified the build and the spec is not failing).