3426 [Flaky Spec] Address timing issues in enterprise users feature specs #3470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kristinalim
changed the title
kristinalim
changed the title
luisramos0
approved these changes
Feb 11, 2019
sauloperez
suggested changes
Feb 11, 2019
| click_link "Users" | ||
| end | ||
|
|
||
| expect(page).to have_selector "table.managers" |
There was a problem hiding this comment.
I wouldn't add this here as we're coupling the actual navigation with an assertion. As a result, in line 133 above we're adding an extra step that we don't need. That being said, I don't think line 101 should need it either. If we have to wait for things to appear on the page, let's find them instead.
There was a problem hiding this comment.
what do you think @kristinalim ?
There was a problem hiding this comment.
@sauloperez I moved check for table presence out of the helper method. Build is green, and I moved this back to Code Review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address timing issues in enterprise users feature specs.
What? Why?
Closes #3426
What should we test?
Semaphore build should be green.
In the long term, this test should also not fail.
Release notes
Changelog Category: Fixed