[Spree Upgrade] Fix admin new order page flow (from order details to customer details) #3436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luisramos0
changed the title
luisramos0
force-pushed
the
2-0-orders-edit
branch
from
a75fd64 to
a8e53ed
Compare
luisramos0
force-pushed
the
2-0-orders-edit
branch
3 times, most recently
from
6a54ad6 to
264fe05
Compare
sauloperez
suggested changes
Feb 7, 2019
|
@sauloperez re tests, this is fixing 2 tests already. |
|
reconsidering testing, I need to add some controller level tests here: spec/controllers/spree/admin/orders_controller_spec.rb |
…ogic and add specs for it
luisramos0
force-pushed
the
2-0-orders-edit
branch
from
264fe05 to
ad0e5bb
Compare
|
I have added specs for the update method (I added them to the same commit without changing the controller). |
sauloperez
approved these changes
Feb 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
Closes #3103
The new spree admin orders controller together with the variant search JS, after adding the variant, run a window.reload on order#update which redirects to customer details after the first variant is added to the order...
I dont think this behaviour of jumping to customer details after the first variant is added is acceptable. So, we need to find a way to keep the user in the order details page when variants are added and keep the behaviour of jumping to customer details if user clicks "update and recalculate" and the order is not complete.
This PR changes the spree admin orders controller to adapt to our needs by redirecting from update to edit when there are errors (and sends the errors in flash errors) so that when a variant is added and the page is reloaded, the current action is edit and the page doesn't jump to the customer details (the jump is configured on the update action).
What should we test?
The 3 specs in #3103 should be green but only together with #3194 (I have verified this in a previous build)