Revert to the ruby racer #3244
Revert to the ruby racer #3244
Conversation
…me developers using osx. We will probably be able to move back to the faster mini racer when we upgrade to newer rails versions
luisramos0
force-pushed
the
ruby-racer
branch
from
70118cf to
4eaaeb3
Compare
|
this build has broken twice already with random errors... |
|
I have staged this in ES and confirmed precompile assets didn't error out. |
|
We should keep an eye on Mojave's support for libv8 and revert this change in the future if we can. I guess that's the underlying problem. |
|
staged this in ES to test asset compilation, I am keeping it there because this can also be used to try to replicate potential problem with variant overrides. |
|
Wow, 211s to 316s is a big jump. Is there an issue open still to investigate speeding up the precompile stage? Should we look for alternatives? |
|
IMO it's better if we focus on getting our app and dependencies up to date. This is just a symptom of how bad our situation is. Chances are that any other solutions might not work with deprecated Ruby and Rails versions... |
|
Is this still on ES @luisramos0 @sauloperez ? Is it tested and OK? |
|
this is on ES yes. |
|
@luisramos0 @sauloperez staging ES URL redirects now to https://appstaging.katuma.org/ which I cannot access apparently... am I looking at the wrong place? |
|
Nope, that's me. I didn't properly restore staging when I played with it last week. EDIT @RachL staging.katuma.org is back online. You will surely need to disable cache either checking "Disable cache" from the Network tab of the dev tools or from a incognito window. |
|
thx @sauloperez I'm starting testing now :) |
|
Ready to go ! Testing notes : https://docs.google.com/document/d/1Ko0YqoytiPBnT_ls6lZeLxIm740FfNHLZbu2CylYx88/edit# |
|
oh my god, I cant believe, my master just works now :-D |
What? Why?
I can't make mini racer work locally (osx mojave) . I cant trace back to the point of failure but it did work at some point.
This is not only my problem as 2 new contributors (I believe all using osx as I am) have also reported this problem.
So, this PR reverts PR #2424.
I suggest we re-open #2100
This PR makes my life (and some new contributors with the same problem) a lot easier but makes the assets compilation move back from 211s to 316s (as noted on #2100).
What should we test?
Asset precompilation should still work correctly. We should make a sanity check of the app.
Release notes
Moved back to therubyracer for asset compilation to avoid trouble caused by the faster mini racer.
Changelog Category: Changed