[Spree Upgrade] Scope variants in line items availability validator #3232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…with quantity zero Stock::Quantifier.can_supply? returns false for an input of zero when stock level is negative
luisramos0
force-pushed
the
2-0-out-of-stock
branch
3 times, most recently
from
a42b89e to
62e7277
Compare
luisramos0
changed the title
mkllnk
approved these changes
Dec 21, 2018
| def validate_quantity(line_item, quantity) | ||
| quantifier = Spree::Stock::Quantifier.new(line_item.variant_id) | ||
| return if quantifier.can_supply? quantity | ||
| line_item.scoper.scope(line_item.variant) |
There was a problem hiding this comment.
Instead of exposing the scoper, you could offer line_item.scope_variant.
I still have a concern about the performance of the scoper used in this way, but that can probably be solved later on.
There was a problem hiding this comment.
yes, I also think performance is best solved later when things are correct.
There was a problem hiding this comment.
@mkllnk I think that would just be more lines of code, I'd need to create a new method in lineitem.
We all do 🙈. We need to all be aware of it when discussing priorities. |
sauloperez
approved these changes
Dec 21, 2018
…y expect statements
luisramos0
force-pushed
the
2-0-out-of-stock
branch
from
62e7277 to
16dbe39
Compare
…_item.scoper and moving Spree::Stock::Quantifier.can_supply? to VariantStock so that it becomes overridable
…pend on Spree::Stock::Quantifier
luisramos0
force-pushed
the
2-0-out-of-stock
branch
from
16dbe39 to
6c70998
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes all 5 commits from #3210, this PRs commits are the last 5.
What? Why?
Closes #3118
When validating line_item.variant stock levels in stock/availability_validator we need to scope variants so that variant overrides stock levels are used instead. Here we re-use the the line_item.scoper so that the variant_overrides are not loaded several times in the handling fo line_items in the same request.
Additional problems solved:
What should we test?
This is one of the final steps in making cart and checkout handle stock levels correctly in v2!
the spec in 3118 (spec/features/consumer/shopping/variant_overrides_spec.rb:152) should be green.
Dependencies
This PR goes after #3210