Disable hiding of hamburger menu upon resize <= 1024px width #2924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some browsers for mobile devices, the address bar is automatically hidden when scrolling down the page. This is not workable if the height of the contents of the off-canvas exceeds the height of the screen, because the latter portion of the contents stays hidden to the user. https://github.com/openfoodfoundation/angular-foundation/blob/0.9.0-20180826174721/src/offcanvas/offcanvas.js
kristinalim
added
the
bug-s2
sigmundpetersen
removed
the
bug-s2
|
@kristinalim that spec fails often in semaphore, just try a rebuild |
mkllnk
approved these changes
Oct 26, 2018
luisramos0
approved these changes
Oct 26, 2018
|
|
||
| # Bind hiding of the off-canvas that only happens when screen width is over 1024px. | ||
| win.bind 'resize.body', -> | ||
| isolatedScope.hide() if $(window).width() > 1024 |
There was a problem hiding this comment.
I think you can use $window
https://docs.angularjs.org/api/ng/service/$window
|
staged staging.openfoodfrance.org |
|
I'm testing it straight away, hopefully it can go into the release!! |
|
I didn't open a file for this, it is working, I can browse the hamburger menu and access the login ! And I can login. Good to go ! |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
Closes #2907
Disable hiding the hamburger menu (off-canvas) upon window resize to less than 1024px width.
In some browsers for mobile devices, the address bar is automatically hidden when scrolling down the page. This is not workable if the height of the contents of the hamburger menu exceeds the height of the screen, because the latter portion of the contents stays hidden to the user.
Refer to code of directive: https://github.com/openfoodfoundation/angular-foundation/blob/0.9.020180826174721/src/offcanvas/offcanvas.js
Merely changing the hamburger menu to be scrollable is quite tangly and will need a lot of testing because of how the DOM elements are laid out, which I think this is counter-productive. The behaviour of automatically closing the hamburger menu is introduced by angular-foundation which has long been unsupported. We should move away from the library rather than work around its features.
What should we test?
Test closed and open hamburger menu for different screen sizes, and switching between landscape and portrait for mobile devices.
Release notes
Changelog Category: Fixed
How is this related to the Spree upgrade?
The behaviour should be checked again if the version of Foundation is upgraded.