-
-
Notifications
You must be signed in to change notification settings - Fork 730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Portuguese and German to list of momentJS locales #2916
Add Portuguese and German to list of momentJS locales #2916
Conversation
…s in the order cycle closure time in the shopfront
this is related to #1819 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💪
@luisramos0 French and Spanish staging do not have the problem. So I guess this one cannot be tested with our current staging servers, can it? |
I think the best approach is to deploy it to any staging server and, after the deploy, someone goes to application.rb and enables pt and de_DE, for example:
I can do this when FR becomes free. |
I staged this one. It's looking good: @RachL do you want to have a look? |
@luisramos0 Yes I'm on it |
@luisramos0 I don't speak Portugues, is it normal to have twice the "em"? Other than that we are good to go |
ah, well spotted! I didnt see it even speaking portuguese 🤣 It will get there on the next deploy. |
The main usage is in the order cycle closure time in the shopfront.
What? Why?
Portuguese katuma shopfronts have the order cycle closure time indication in english. This fixes the problem.
German was also missing. Now fixed:
What should we test?
In Portuguese or German, the shopfront message should not display "in x days" but instead a localed message.
Release notes
Changelog Category: Fixed
Fixed Portuguese and German translation problem in the shopfront order cycle closure time.
How is this related to the Spree upgrade?
not related.