Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Portuguese and German to list of momentJS locales #2916

Merged
merged 1 commit into from
Oct 25, 2018

Conversation

luisramos0
Copy link
Contributor

The main usage is in the order cycle closure time in the shopfront.

What? Why?

Portuguese katuma shopfronts have the order cycle closure time indication in english. This fixes the problem.
German was also missing. Now fixed:
screen shot 2018-10-23 at 17 57 58

What should we test?

In Portuguese or German, the shopfront message should not display "in x days" but instead a localed message.

Release notes

Changelog Category: Fixed
Fixed Portuguese and German translation problem in the shopfront order cycle closure time.

How is this related to the Spree upgrade?

not related.

…s in the order cycle closure time in the shopfront
@luisramos0 luisramos0 self-assigned this Oct 23, 2018
@luisramos0
Copy link
Contributor Author

this is related to #1819

Copy link
Contributor

@Matt-Yorkley Matt-Yorkley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪

@RachL
Copy link
Contributor

RachL commented Oct 24, 2018

@luisramos0 French and Spanish staging do not have the problem. So I guess this one cannot be tested with our current staging servers, can it?

@luisramos0
Copy link
Contributor Author

luisramos0 commented Oct 24, 2018

I think the best approach is to deploy it to any staging server and, after the deploy, someone goes to application.rb and enables pt and de_DE, for example:

  • AVAILABLE_LOCALES: en, es, pt, de_DE
    A Unicorn restart will make it available for test.

I can do this when FR becomes free.

@luisramos0 luisramos0 added the pr-staged-fr staging.coopcircuits.fr label Oct 25, 2018
@luisramos0
Copy link
Contributor Author

I staged this one.
I added pt and de_DE to application.yml and restarted unicorn.

It's looking good:
https://staging.openfoodfrance.org/enterprise-2/shop
https://staging.openfoodfrance.org/enterprise-2/shop?locale=pt
https://staging.openfoodfrance.org/enterprise-2/shop?locale=de_DE

@RachL do you want to have a look?

@RachL
Copy link
Contributor

RachL commented Oct 25, 2018

@luisramos0 Yes I'm on it

@RachL
Copy link
Contributor

RachL commented Oct 25, 2018

image

image

@luisramos0 I don't speak Portugues, is it normal to have twice the "em"? Other than that we are good to go

@RachL RachL removed the pr-staged-fr staging.coopcircuits.fr label Oct 25, 2018
@luisramos0
Copy link
Contributor Author

ah, well spotted! I didnt see it even speaking portuguese 🤣
It's a problem in the translation, I have just removed de "em" in transifex:
https://www.transifex.com/open-food-foundation/open-food-network/translate/#pt/enyml/63684034?q=key_name%3Aenterprises_next_closing+key%3Aenterprises_next_closing

It will get there on the next deploy.
Nothing to fix on this PR.

@sauloperez sauloperez merged commit 7cac463 into openfoodfoundation:master Oct 25, 2018
@luisramos0 luisramos0 deleted the date-transl-fix branch October 25, 2018 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants