Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2765 Fix geocoding to display enterprises on map #2872

Merged
merged 10 commits into from
Oct 22, 2018
Merged

2765 Fix geocoding to display enterprises on map #2872

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
b109f6d
Remove temporary reporting code
mkllnk Oct 16, 2018
c4437a6
Style address decorator
mkllnk Oct 16, 2018
34849c4
Reduce complexity and duplication
mkllnk Oct 16, 2018
5021ed9
Simplify by using Rails tools
mkllnk Oct 16, 2018
a8705ca
Simplify address methods
mkllnk Oct 16, 2018
61797ff
Restrict deletion of address explicitely
mkllnk Oct 16, 2018
8fb81bb
Configure Geocoder with API key as required by Google
mkllnk Oct 16, 2018
e96cab9
Convert specs to RSpec 3.7.1 syntax with Transpec
mkllnk Oct 17, 2018
d197c85
Test address deletion
mkllnk Oct 18, 2018
9698fd3
Style spec
mkllnk Oct 18, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 0 additions & 23 deletions app/models/spree/address_decorator.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,27 +37,4 @@ def address_part2
def touch_enterprise
enterprise.andand.touch
end

# We have a hard-to-track-down bug around invalid addresses with all-nil fields finding
# their way into the database. I don't know what the source of them is, so this patch
# is designed to track them down.
# This is intended to be a temporary investigative measure, and should be removed from the
# code base shortly. If it's past 17-10-2013, take it out.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's exactly 5 years later!!!

#
#-- Rohan, 17-9-2913
def create
if self.zipcode.nil?
Bugsnag.notify RuntimeError.new('Creating a Spree::Address with nil values')
end

super
end

def update(attribute_names = @attributes.keys)
if self.zipcode.nil?
Bugsnag.notify RuntimeError.new('Updating a Spree::Address with nil values')
end

super(attribute_names)
end
end
15 changes: 0 additions & 15 deletions spec/models/spree/addresses_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,19 +54,4 @@
expect { Spree::Address.new.country = "A country" }.to raise_error ActiveRecord::AssociationTypeMismatch
end
end

describe "notifying bugsnag when saved with missing data" do
it "notifies on create" do
Bugsnag.should_receive(:notify)
a = Spree::Address.new zipcode: nil
a.save validate: false
end

it "notifies on update" do
Bugsnag.should_receive(:notify)
a = create(:address)
a.zipcode = nil
a.save validate: false
end
end
end