-
-
Notifications
You must be signed in to change notification settings - Fork 730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump figaro from 0.7.0 to 1.1.1 #2871
Conversation
Bumps [figaro](https://github.com/laserlemon/figaro) from 0.7.0 to 1.1.1. - [Release notes](https://github.com/laserlemon/figaro/releases) - [Changelog](https://github.com/laserlemon/figaro/blob/master/CHANGELOG.md) - [Commits](laserlemon/figaro@v0.7.0...v1.1.1) Signed-off-by: dependabot[bot] <[email protected]>
@@ -846,6 +844,7 @@ DEPENDENCIES | |||
uglifier (>= 1.0.3) | |||
unicorn | |||
unicorn-rails | |||
web! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that web is the engine...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I explain this here:
#2735 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know, it's just that it's moving it up and down the file...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's putting it in the right place (alphabetical order), I edited the gemfile.lock myself (renamed the engine)! that's what it is correcting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so the move is from the alphabetical order position of "content" (previous name) to "web" (new name)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool. This whole dependabot thing makes me understand which gems are actually doing what in our code base. :-)
I had a look at https://github.com/laserlemon/figaro#how-do-i-upgrade-to-figaro-10 which mentions breaking changes. But since we don't use Figaro.env
and we don't use the Rake task, we are fine. Everything should work as before.
Anything to test on this one? |
Just a sanity check. If the application.yml can't be loaded properly, the application crashes. |
Sally just tested. All good. Merging. |
Bumps figaro from 0.7.0 to 1.1.1.
Changelog
Sourced from figaro's changelog.
Commits
d97fb63
Target version 1.1.1fb000e4
Add a missing changelog entry7e9d34b
Merge pull request #191 from feature/no-crash-on-empty-blocksba95740
add a spec for the empty-env config1bab1cc
allow empty environment configuration7d950c1
Target version 1.1.0619b47a
Merge pull request #177 from fny/heroku-remote-flag-support2d5f693
Upgrade to Travis' Docker infrastructure5fde2a7
Build against Ruby 2.231e14a8
Build against Rails 4.2 stable rather than betaDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Note: This repo was added to Dependabot recently, so you'll receive a maximum of 5 PRs for your first few update runs. Once an update run creates fewer than 5 PRs we'll remove that limit.
You can always request more updates by clicking
Bump now
in your Dependabot dashboard.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge@dependabot reopen
will reopen this PR if it is closed@dependabot ignore this [patch|minor|major] version
will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)@dependabot use these labels
will set the current labels as the default for future PRs for this repo and language@dependabot use these reviewers
will set the current reviewers as the default for future PRs for this repo and language@dependabot use these assignees
will set the current assignees as the default for future PRs for this repo and language@dependabot use this milestone
will set the current milestone as the default for future PRs for this repo and language@dependabot badge me
will comment on this PR with code to add a "Dependabot enabled" badge to your readmeAdditionally, you can set the following in your Dependabot dashboard:
Finally, you can contact us by mentioning @dependabot.