Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump figaro from 0.7.0 to 1.1.1 #2871

Merged
merged 1 commit into from
Nov 2, 2018
Merged

Conversation

dependabot-preview[bot]
Copy link
Contributor

Bumps figaro from 0.7.0 to 1.1.1.

Changelog

Sourced from figaro's changelog.

1.1.1 / 2015-04-30

  • [BUGFIX] Fix crash when environment-specific configuration is nil

1.1.0 / 2015-01-27

  • [FEATURE] Support --remote when setting Heroku configuration
  • [ENHANCEMENT] Test against Rails 4.2 (stable)

1.0.0 / 2014-09-17

  • [BUGFIX] Make calls to Heroku with a clean Bundler environment
  • [ENHANCEMENT] Remove Rails as a runtime dependency
  • [FEATURE] Replace the Rails generator with the figaro install task
  • [ENHANCEMENT] Rename the Figaro.require method to Figaro.require_keys
  • [ENHANCEMENT] Begin to test against Rails 4.2 (beta)

1.0.0.rc1 / 2014-04-17

  • [FEATURE] Add bang and boolean methods to Figaro.env
  • [ENHANCEMENT] Detach Figaro.env from the configuration file hash
  • [FEATURE] Add the ability to swap Figaro's application adapter
  • [FEATURE] Warn when configuration keys or values are not strings
  • [FEATURE] Enable Figaro to load multiple times, overwriting previous values
  • [FEATURE] Load Figaro configuration prior to database configuration
  • [ENHANCEMENT] Test against Ruby 2.1
  • [ENHANCEMENT] Test against Rails 4.1
  • [FEATURE] Replace Rake task with figaro executable
  • [BUGFIX] Fix character escaping for figaro heroku:set on Windows
  • [FEATURE] Warn when a preexisting configuration key is skipped during load
  • [FEATURE] Add the ability to fail fast in the absence of required keys
  • [FEATURE] Tie into Rails' earliest possible before_configuration hook
Commits
  • d97fb63 Target version 1.1.1
  • fb000e4 Add a missing changelog entry
  • 7e9d34b Merge pull request #191 from feature/no-crash-on-empty-blocks
  • ba95740 add a spec for the empty-env config
  • 1bab1cc allow empty environment configuration
  • 7d950c1 Target version 1.1.0
  • 619b47a Merge pull request #177 from fny/heroku-remote-flag-support
  • 2d5f693 Upgrade to Travis' Docker infrastructure
  • 5fde2a7 Build against Ruby 2.2
  • 31e14a8 Build against Rails 4.2 stable rather than beta
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Note: This repo was added to Dependabot recently, so you'll receive a maximum of 5 PRs for your first few update runs. Once an update run creates fewer than 5 PRs we'll remove that limit.

You can always request more updates by clicking Bump now in your Dependabot dashboard.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot ignore this [patch|minor|major] version will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Pull request limits (per update run and/or open at any time)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

Finally, you can contact us by mentioning @dependabot.

@@ -846,6 +844,7 @@ DEPENDENCIES
uglifier (>= 1.0.3)
unicorn
unicorn-rails
web!
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bundler, why are u doing this?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that web is the engine...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I explain this here:
#2735 (comment)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know, it's just that it's moving it up and down the file...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's putting it in the right place (alphabetical order), I edited the gemfile.lock myself (renamed the engine)! that's what it is correcting.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so the move is from the alphabetical order position of "content" (previous name) to "web" (new name)

Copy link
Member

@mkllnk mkllnk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. This whole dependabot thing makes me understand which gems are actually doing what in our code base. :-)

I had a look at https://github.com/laserlemon/figaro#how-do-i-upgrade-to-figaro-10 which mentions breaking changes. But since we don't use Figaro.env and we don't use the Rake task, we are fine. Everything should work as before.

@sigmundpetersen
Copy link
Contributor

Anything to test on this one?

@mkllnk
Copy link
Member

mkllnk commented Nov 1, 2018

Just a sanity check. If the application.yml can't be loaded properly, the application crashes.

@mkllnk
Copy link
Member

mkllnk commented Nov 2, 2018

Sally just tested. All good. Merging.

@mkllnk mkllnk merged commit cbfe1b5 into master Nov 2, 2018
@dependabot-preview dependabot-preview bot deleted the dependabot/bundler/figaro-1.1.1 branch November 2, 2018 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants