Instagram pattern

[albarnaz]

Issue: #1760

There is no suggestion in the Instagram empty field in enterprise profile setup menu. Some users copy-paste the full URL on their page. That doesn't work because what is expected is only their Instagram user pseudo.

FIX

Add an before save to check if the user enter the whole URL, and extract and store just the handle.

So, if the user enter "www.instagram.com/my_user", we store just "@my_user".

[mkllnk]

Thank you! This is great.

Since there are some detours in the commit history, we should squash the commits when merging.

Would you like to continue working on this? I have some ideas how to further improve this.

1. Use a more precise regular expression to test the URL. Your current test would fail if someone had the handle @i_love_instagram.com which is valid.
2. Convert your before_save check into a before_validation check.
3. Include a validation check for the handle. I think it would be a regex like /^@[a-zA-Z0-9._]{1,30}$/.

[sobrinho]

Maybe we can do something like:

validates :instagram, format: /\A@[a-zA-Z0-9._]{1,30}\z/

def instagram=(value)
  write_attribute(:instagram, value.try!(:gsub, %r{\Ahttps?://(?:www.)?instagram.com/([a-zA-Z0-9._]{1,30})/?\z}, '@\1'))
end

That way we care about that manipulating on setter and we care about the format on the validation.

[mkllnk]

Wow, this is so much better than my suggestions. I commented on a few things below that can still be improved.

[mkllnk]

Nice! Thank you. That's really good now.

[sigmundpetersen]

How is this related to #2849 ? Can the other be closed or are they complementary? @albarnaz

[luisramos0]

nice!

[luisramos0]

they are complementary @sigmundpetersen

[luisramos0]

staged: https://staging.openfoodfrance.org

[RachL]

Ready to go :) Testing notes: https://docs.google.com/document/d/1e8eWTX7YVYkkxYXpDZwXKiR_vUsRvpjrpqFvBElRfHI/edit#

[mkllnk]

@RachL Sally found an issue with this pull request: #2849 (comment)

We should have included in the test description that you need to check on a profile page if the Instagram link is actually working. :-D

[RachL]

@mkllnk @sstead ouch my bad :/ But I've re-tested in our production and we don't get the error. Everything saves correctly, so I'm not sure if it was introduce by 2849. But anyway now it is reverted.