[README] Updated build status badge #2826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @73VW! Welcome! If you have any questions setting up the dev env, with Github, etc. feel free to ask on the dev channel of our Slack team. |
sauloperez
approved these changes
Oct 4, 2018
luisramos0
approved these changes
Oct 4, 2018
|
changing the README, no tests are necessary. |
|
Are you gonna merge it? |
|
Hey @73VW , yes, "ready to go" means that someone can just merge it. I'm not currently merging PRs into master myself. Someone else will do it soon. |
|
@luisramos0 I didn't know this, thanks! |
|
Third time today I've seen this test giving a flaky failure:
Edit: fourth time now, I'll take a look at it. |
|
Can we skip it and then tackle it in an issue? We've done this before. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
Closes #2822
What should we test?
Nothing.
Release notes
Changelog Category: Fixed
How is this related to the Spree upgrade?
Discourse thread
Dependencies
Documentation updates