Make 'Clear All' button work on order cycle page #2821
Conversation
| $scope.scheduleFilter = 0 | ||
| $scope.involvingFilter = 0 | ||
| $scope.query = '' | ||
| $scope.resetSelectFilters() |
There was a problem hiding this comment.
sorry @nikobozi, I'm not very angular-savy. When does this get executed? can you explain a bit?
There was a problem hiding this comment.
it's when the controller is loaded @sauloperez
There was a problem hiding this comment.
yes, and it can then be triggered via a ng-click directive from a DOM element, which in this case is the input button in this template views/admin/order_cycles/_filters.html.haml
|
Hi @nikobozi ! Welcome! Very happy to have your help with it. If you have any questions setting up the dev env, with Github, etc. feel free to ask on the dev channel of our Slack team. |
| $scope.scheduleFilter = 0 | ||
| $scope.involvingFilter = 0 | ||
| $scope.query = '' | ||
| $scope.resetSelectFilters() |
There was a problem hiding this comment.
it's when the controller is loaded @sauloperez
|
Staged on https://staging.katuma.org |
|
Everything looks good ! Good job and welcome @nikobozi ! https://docs.google.com/document/d/1Gw7Zy3xJsMboJRnTZinQ5OBJBxp_HqvD1DCI7KQqOdY/edit# |
|
Congrats @nikobozi and thanks again! |
|
thanks :) |
What? Why?
Closes #2362
The expected functionality (clearing filters) didn't work because there was no corresponding function in the controller.
What should we test?
/admin/order_cyclesThe filters should be reset to initial state
Release notes
Make 'Clear All' button work on admin order cycles page