[Spree Upgrade] Destroy all shipments when clearing order #2767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now we only clear the order's shipping_method, and in Spree 2.0 it can have many shipments.
luisramos0
changed the title
mkllnk
approved these changes
Sep 25, 2018
sauloperez
approved these changes
Sep 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now we only clear the order's shipping_method, and in Spree 2.0 it can have many shipments.
What? Why?
Closes #2681
I think @sauloperez solution is valid. This PR is just cherry picking the commit and resolving conflicts.
What should we test?
Fixes order.empty route.