2655 fix admin payments #2697
Merged
2655 fix admin payments #2697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can't always rely on other parts of the code been loaded first. We need to declare dependencies so that they are always present. I just ran into this problem in my dev environment.
sauloperez
approved these changes
Sep 13, 2018
luisramos0
approved these changes
Sep 13, 2018
|
@mkllnk I am moving to Test Ready with two reviews done. But please move back if @kristinalim review is required. |
|
Testing Notes One thing is causing an error - if I try to create a partial payment for a payment method that has a fee attached I get an error Things working:
https://docs.google.com/document/d/1c6Wy8O6aYmpGvmXkUb3UpNFhBVP4uYULTa8Pd-LPIGI/edit# |
|
Looks like you discovered an old bug. I filed it as #2724 now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
Closes #2655.
The new Stripe code is loading payment methods including their calculated fees. But it forgot to pass on the current order to calculate fees on. Trying to create a payment for an order failed if the enterprise had certain payment fees configured.
What should we test?
Creating a payment from the admin interface.
Creating a payment should work.
Release notes
Fixed charging customers from the admin interface which failed when certain payment fees where configured.
Changelog Category: Fixed