Custom user guide link in enterprise welcome mail #2687
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HugsDaniel
force-pushed
the
2631_user_guide_link_in_welcome_mail
branch
from
6f09ba9 to
4e67566
Compare
|
I don't understand the difference with #2686. I see the exact same code. |
|
There's one more commit but I guess I could put it directly in #2686 since it's not a major modif |
|
You can replace the base of this PR to that other branch if that is what it is. |
|
Now you continued working on #2686. Can we close this one? |
|
Yes ! I close it now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
Closes #2631
Following #2686
Adding dynamic user guide link to enterprise welcome email.
What should we test?
In the enterprise welcome email, the custom user guide link should be displayed.
Changelog Category: Changed