Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow fixing and customizing translations for order cancellation and shipment emails #2658

Conversation

kristinalim
Copy link
Member

Add translation keys for order cancellation and shipment emails

What? Why?

These emails are not correctly translated for some languages. For example, for French, these are still in English.

What should we test?

For convenience, you can do all of these as admin.

Order cancellation: (see #2375 (comment))

Go to order, cancel an order you have made, and see the email you receive

Order shipment: (from #2300 (comment))

Make an order, go the "orders" page
Click on the small "ship" icon on the right of the order line
Check your mailbox

Release notes

  • Allow custom translation of order cancellation and shipment emails for customers

Changelog Category: Fixed

How is this related to the Spree upgrade?

It is possible that the new emails use new translation keys which are not included here.

@kristinalim kristinalim self-assigned this Sep 7, 2018
@kristinalim kristinalim force-pushed the translations-order_and_shipment_emails branch from 262fe29 to 2cf608f Compare September 7, 2018 09:35
Copy link
Contributor

@luisramos0 luisramos0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mkllnk
Copy link
Member

mkllnk commented Sep 13, 2018

Staged on https://staging.openfoodnetwork.org.au/.

@mkllnk mkllnk added the pr-staged-au staging.openfoodnetwork.org.au label Sep 13, 2018
@RachL
Copy link
Contributor

RachL commented Sep 13, 2018

Hello @mkllnk how can I test this on an english staging? I've tested emails and they are send correctly... but in English.... Can the translation be updated somehow?

@mkllnk
Copy link
Member

mkllnk commented Sep 14, 2018

Testing the English version is the best we can do. Even if we changed the language, the text is not translated yet. This change just makes it available for translation. So after we merged this pull request, it will appear in Transifex. So the only thing we can do is check that this works in English and didn't break anything.

@mkllnk mkllnk removed the pr-staged-au staging.openfoodnetwork.org.au label Sep 14, 2018
@mkllnk mkllnk merged commit 1000bd4 into openfoodfoundation:master Sep 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants