Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed old files that were used with, now unsupported, heroku #2636

Merged
merged 1 commit into from
Sep 3, 2018

Conversation

luisramos0
Copy link
Contributor

@luisramos0 luisramos0 commented Sep 2, 2018

What? Why?

Raised from the review of #238.

These files are no longer required because heroku is no longer supporte.

What should we test?

I don't think this needs testing.

Release notes

Changelog Category: Removed
Removed old files used in, now unsupported, heroku.

Copy link
Member

@mkllnk mkllnk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally. :-) This will avoid confusion.

@daniellemoorhead daniellemoorhead changed the title Removed old files that were used with, now unsuported, heroku Removed old files that were used with, now unsupported, heroku Sep 3, 2018
@Matt-Yorkley
Copy link
Contributor

We can still have some release notes for this though, @luisramos0 😉

@luisramos0
Copy link
Contributor Author

ahah, I always feel weird about putting release notes for these tiny PRs... but well, I just added something :-)

@sauloperez sauloperez merged commit 903d700 into openfoodfoundation:master Sep 3, 2018
@luisramos0 luisramos0 deleted the heroku_dead_code branch September 3, 2018 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants