Adds comments for setting up timezone in application.yml #2635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sauloperez
suggested changes
Sep 3, 2018
config/application.yml.example
Outdated
| @@ -4,6 +4,7 @@ | |||
| # Minimum 30 but usually 128 characters. To obtain run 'rake secret', or faster, 'openssl rand -hex 128' | |||
| SECRET_TOKEN: xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx | |||
|
|
|||
| # Time zone must match the operating system time zone in order to pass all tests. This is a string which is the key for the MAPPING hash constant in the ActiveSupport::TimeZone class. Documentation for this class including the entire hash can be found here: https://api.rubyonrails.org/classes/ActiveSupport/TimeZone.html | |||
There was a problem hiding this comment.
Could you please wrap this long line. It's hard to read?
There was a problem hiding this comment.
Good point. Changes submitted.
sauloperez
approved these changes
Sep 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
This adds comments to the application.yml.example file for correctly setting up the timezone locally.
Closes #[the issue number this PR is related to] N/A
The time zone used must match the OS time zone to pass tests. Figuring out how to set this correctly took unnecessary time.
What should we test?
This change made no changes to executed code. All current tests are passing.
Release notes
Added time zone comments to application.yml.example
Changelog Category: Added |