Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security] Bump rubyzip from 1.2.1 to 1.2.2 #2628

Merged
merged 1 commit into from
Sep 7, 2018

Conversation

dependabot-preview[bot]
Copy link
Contributor

Bumps rubyzip from 1.2.1 to 1.2.2. This update includes security fixes.

Vulnerabilities fixed

Sourced from The Ruby Advisory Database.

Directory Traversal in rubyzip
rubyzip version 1.2.1 and earlier contains a Directory Traversal vulnerability
in Zip::File component that can result in write arbitrary files to the filesystem.
If a site allows uploading of .zip files, an attacker can upload a malicious file
which contains symlinks or files with absolute pathnames "../" to write arbitrary
files to the filesystem.

Patched versions: >= 1.2.2
Unaffected versions: none

Commits
  • d07b13a Merge pull request #376 from jdleesmiller/fix-cve-2018-1000544
  • fd81bd5 Bump version to 1.2.2
  • cf35774 Bump version to 1.3.0
  • ffb374c Bump version to 2.0.0
  • 8a1de58 Expand from root rather than current working directory
  • 3dd165b Disable symlinks and check for path traversal
  • ffebfa3 Consolidate path traversal tests
  • 9c468f3 Add jwilk's path traversal tests
  • 0586329 Trigger CI again
  • cf71583 Move jruby to allow failures matrix till crc uint 32 issues are resolved
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Note: This repo was added to Dependabot recently, so you'll receive a maximum of 5 PRs for your first few update runs. Once an update run creates fewer than 5 PRs we'll remove that limit.

You can always request more updates by clicking Bump now in your Dependabot dashboard.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot ignore this [patch|minor|major] version will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Pull request limits (per update run and/or open at any time)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

Finally, you can contact us by mentioning @dependabot.

@dependabot-preview dependabot-preview bot added dependencies security Pull requests that address a security vulnerability labels Aug 31, 2018
@kristinalim kristinalim self-requested a review September 1, 2018 09:08
Copy link
Member

@kristinalim kristinalim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned in the PR description, this upgrade includes a security fix.

The gem is used by roo, which we use for product imports. PR looks good and safe to merge, but needs a smoke test for product import using XLS, XLSX, and ODS file types.

@mkllnk mkllnk added the pr-staged-au staging.openfoodnetwork.org.au label Sep 5, 2018
@mkllnk
Copy link
Member

mkllnk commented Sep 5, 2018

Staged on https://staging1.openfood.com.au/.

@RachL RachL self-assigned this Sep 6, 2018
@RachL
Copy link
Contributor

RachL commented Sep 6, 2018

Here are my testing notes:
https://docs.google.com/document/d/1UukQuKv4J-xEGObz-SgsdFSw7cMdOa4p83yRB3Wfkys/edit#

I've tested csv as well and some error messages were not clear, but those are covered by other PR if I'm not mistaken. So this is ready to go.

@RachL RachL removed the pr-staged-au staging.openfoodnetwork.org.au label Sep 6, 2018
@mkllnk mkllnk merged commit 937da27 into master Sep 7, 2018
@dependabot-preview dependabot-preview bot deleted the dependabot/bundler/rubyzip-1.2.2 branch September 7, 2018 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies security Pull requests that address a security vulnerability tech debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants