Favor #public_send over #send using Rubocop's cop

.rubocop.yml

@@ -33,6 +33,9 @@ Style/HashSyntax:
   Enabled: true
   EnforcedStyle: ruby19_no_mixed_keys
 
+Style/Send:
+  Enabled: true
+
 Layout/MultilineMethodCallIndentation:
   Enabled: true
   EnforcedStyle: indented

app/controllers/admin/contents_controller.rb

@@ -14,7 +14,7 @@ def edit
     def update
       params.each do |name, value|
         if ContentConfig.has_preference?(name) || ContentConfig.has_attachment?(name)
-          ContentConfig.send("#{name}=", value)
+          ContentConfig.public_send("#{name}=", value)
         end
       end
 

app/controllers/admin/inventory_items_controller.rb

@@ -19,7 +19,7 @@ class InventoryItemsController < ResourceController
     # we can authorise #create using an object with required attributes
     def build_resource
       if parent_data.present?
-        parent.send(controller_name).build
+        parent.public_send(controller_name).build
       else
         model_class.new(params[object_name]) # This line changed
       end

app/controllers/admin/product_import_controller.rb

@@ -53,7 +53,7 @@ def process_data(method)
       @importer = ProductImport::ProductImporter.new(File.new(params[:filepath]), spree_current_user, start: params[:start], end: params[:end], settings: params[:settings])
 
       begin
-        @importer.send("#{method}_entries")
+        @importer.public_send("#{method}_entries")
       rescue StandardError => e
         render json: e.message, response: 500
         return false

app/controllers/admin/resource_controller.rb

@@ -15,18 +15,18 @@ def new_object_url(options = {})
 
     def edit_object_url(object, options = {})
       if parent_data.present?
-        main_app.send "edit_admin_#{model_name}_#{object_name}_url", parent, object, options
+        main_app.public_send "edit_admin_#{model_name}_#{object_name}_url", parent, object, options
       else
-        main_app.send "edit_admin_#{object_name}_url", object, options
+        main_app.public_send "edit_admin_#{object_name}_url", object, options
       end
     end
 
     def object_url(object = nil, options = {})
       target = object ? object : @object
       if parent_data.present?
-        main_app.send "admin_#{model_name}_#{object_name}_url", parent, target, options
+        main_app.public_send "admin_#{model_name}_#{object_name}_url", parent, target, options
       else
-        main_app.send "admin_#{object_name}_url", target, options
+        main_app.public_send "admin_#{object_name}_url", target, options
       end
     end
 

app/controllers/enterprises_controller.rb

@@ -77,7 +77,7 @@ def reset_distributor(order, distributor)
 
   def reset_user_and_customer(order)
     order.associate_user!(spree_current_user) if order.user.blank? || order.email.blank?
-    order.send(:associate_customer) if order.customer.nil? # Only associates existing customers
+    order.__send__(:associate_customer) if order.customer.nil? # Only associates existing customers
   end
 
   def reset_order_cycle(order, distributor)

app/controllers/shop_controller.rb

@@ -44,7 +44,7 @@ def changeable_orders_alert
   private
 
   def filtered_json(products_json)
-    if applicator.send(:rules).any?
+    if applicator.rules.any?
       filter(products_json)
     else
       products_json

app/controllers/spree/admin/general_settings_controller_decorator.rb

@@ -10,6 +10,6 @@ def edit
         @preferences_general << :bugherd_api_key
       end
     end
-    GeneralSettingsController.send(:prepend, GeneralSettingsEditPreferences)
+    GeneralSettingsController.prepend(GeneralSettingsEditPreferences)
   end
 end

app/controllers/spree/admin/payment_methods_controller_decorator.rb

@@ -10,7 +10,7 @@ module Admin
       # Only show payment methods that user has access to and sort by distributor name
       # ! Redundant code copied from Spree::Admin::ResourceController with modifications marked
       def collection
-        return parent.send(controller_name) if parent_data.present?
+        return parent.public_send(controller_name) if parent_data.present?
         collection = if model_class.respond_to?(:accessible_by) &&
                          !current_ability.has_block?(params[:action], model_class)
 

app/controllers/spree/admin/payments_controller_decorator.rb

@@ -10,7 +10,7 @@ def fire
 
     # Because we have a transition method also called void, we do this to avoid conflicts.
     event = "void_transaction" if event == "void"
-    if @payment.send("#{event}!")
+    if @payment.public_send("#{event}!")
       flash[:success] = t(:payment_updated)
     else
       flash[:error] = t(:cannot_perform_operation)

app/controllers/spree/admin/resource_controller_decorator.rb

@@ -13,4 +13,4 @@ def load_resource
   end
 end
 
-Spree::Admin::ResourceController.send(:prepend, AuthorizeOnLoadResource)
+Spree::Admin::ResourceController.prepend(AuthorizeOnLoadResource)

app/controllers/spree/admin/shipping_methods_controller_decorator.rb

@@ -7,7 +7,7 @@ module Admin
       # Sort shipping methods by distributor name
       # ! Code copied from Spree::Admin::ResourceController with two added lines
       def collection
-        return parent.send(controller_name) if parent_data.present?
+        return parent.public_send(controller_name) if parent_data.present?
 
         collection = if model_class.respond_to?(:accessible_by) &&
                          !current_ability.has_block?(params[:action], model_class)

app/helpers/angular_form_builder.rb

@@ -7,10 +7,6 @@ def ng_fields_for(record_name, *args, &block)
   end
 
   def ng_text_field(method, options = {})
-    # @object_name --> "enterprise_fee_set"
-    # @fields_for_record_name --> :collection
-    # @object.send(@fields_for_record_name).first.class.to_s.underscore --> enterprise_fee
-
     value = "{{ #{angular_model(method)} }}"
     options.reverse_merge!({'id' => angular_id(method)})
 
@@ -46,6 +42,6 @@ def angular_id(method)
   end
 
   def angular_model(method)
-    "#{@object.send(@fields_for_record_name).first.class.to_s.underscore}.#{method}"
+    "#{@object.public_send(@fields_for_record_name).first.class.to_s.underscore}.#{method}"
   end
 end

app/helpers/angular_form_helper.rb

@@ -11,7 +11,7 @@ def ng_options_for_select(container, angular_field=nil)
 
   def ng_options_from_collection_for_select(collection, value_method, text_method, angular_field)
     options = collection.map do |element|
-      [element.send(text_method), element.send(value_method)]
+      [element.public_send(text_method), element.public_send(value_method)]
     end
 
     ng_options_for_select(options, angular_field)

app/helpers/application_helper.rb

@@ -15,7 +15,7 @@ def ng_form_for(name, *args, &block)
   # spree.foo_path in any view rendered from non-spree-namespaced controllers.
   def method_missing(method, *args, &block)
     if (method.to_s.end_with?('_path') || method.to_s.end_with?('_url')) && spree.respond_to?(method)
-      spree.send(method, *args)
+      spree.public_send(method, *args)
     else
       super
     end

app/models/column_preference.rb

@@ -20,7 +20,7 @@ class ColumnPreference < ActiveRecord::Base
 
   def self.for(user, action_name)
     stored_preferences = where(user_id: user.id, action_name: action_name)
-    default_preferences = send("#{action_name}_columns")
+    default_preferences = __send__("#{action_name}_columns")
     filter(default_preferences, user, action_name)
     default_preferences.each_with_object([]) do |(column_name, default_attributes), preferences|
       stored_preference = stored_preferences.find_by_column_name(column_name)
@@ -37,7 +37,7 @@ def self.for(user, action_name)
   private
 
   def self.valid_columns_for(action_name)
-    send("#{action_name}_columns").keys.map(&:to_s)
+    __send__("#{action_name}_columns").keys.map(&:to_s)
   end
 
   def self.known_actions

app/models/model_set.rb

@@ -12,7 +12,7 @@ def initialize(klass, collection, attributes={}, reject_if=nil, delete_if=nil)
     @collection = attributes[:collection] if attributes[:collection]
 
     attributes.each do |name, value|
-      send("#{name}=", value)
+      public_send("#{name}=", value)
     end
   end
 

app/models/product_import/entry_processor.rb

@@ -204,7 +204,7 @@ def assign_defaults(object, entry)
         when 'overwrite_all'
           object.assign_attributes(attribute => setting['value'])
         when 'overwrite_empty'
-          if object.send(attribute).blank? || ((attribute == 'on_hand' || attribute == 'count_on_hand') && entry.on_hand_nil)
+          if object.public_send(attribute).blank? || ((attribute == 'on_hand' || attribute == 'count_on_hand') && entry.on_hand_nil)
             object.assign_attributes(attribute => setting['value'])
           end
         end

app/models/product_import/entry_validator.rb

@@ -169,7 +169,7 @@ def tax_and_shipping_validation(entry, type, category, index)
       return if category.blank?
 
       if index.key? category
-        entry.send("#{type}_category_id=", index[category])
+        entry.public_send("#{type}_category_id=", index[category])
       else
         mark_as_invalid(entry, attribute: "#{type}_category", error: I18n.t('admin.product_import.model.not_found'))
       end

app/models/product_import/spreadsheet_entry.rb

@@ -71,7 +71,7 @@ def assign_units(attrs)
 
       units.converted_attributes.each do |attr, value|
         if respond_to?("#{attr}=")
-          send("#{attr}=", value) unless non_product_attributes.include?(attr)
+          public_send("#{attr}=", value) unless non_product_attributes.include?(attr)
         end
       end
     end

app/models/proxy_order.rb

@@ -19,7 +19,7 @@ class ProxyOrder < ActiveRecord::Base
   def state
     # NOTE: the order is important here
     %w(canceled paused pending cart).each do |state|
-      return state if send("#{state}?")
+      return state if __send__("#{state}?")
     end
     order.state
   end
@@ -32,7 +32,7 @@ def cancel
     return false unless order_cycle.orders_close_at.andand > Time.zone.now
     transaction do
       update_column(:canceled_at, Time.zone.now)
-      order.send('cancel') if order
+      order.cancel if order
       true
     end
   end
@@ -41,7 +41,7 @@ def resume
     return false unless order_cycle.orders_close_at.andand > Time.zone.now
     transaction do
       update_column(:canceled_at, nil)
-      order.send('resume') if order
+      order.resume if order
       true
     end
   end

app/models/spree/calculator/default_tax_decorator.rb

@@ -18,15 +18,15 @@ def compute_order(order)
 
     # Added this block, finds relevant fees for each line_item, calculates the tax on them, and returns the total tax
     per_item_fees_total = order.line_items.sum do |line_item|
-      calculator.send(:per_item_enterprise_fee_applicators_for, line_item.variant)
+      calculator.per_item_enterprise_fee_applicators_for(line_item.variant)
         .select { |applicator| (!applicator.enterprise_fee.inherits_tax_category && applicator.enterprise_fee.tax_category == rate.tax_category) ||
-          (applicator.enterprise_fee.inherits_tax_category && line_item.product.tax_category == rate.tax_category) 
+          (applicator.enterprise_fee.inherits_tax_category && line_item.product.tax_category == rate.tax_category)
         }
         .sum { |applicator| applicator.enterprise_fee.compute_amount(line_item) }
     end
 
     # Added this block, finds relevant fees for whole order, calculates the tax on them, and returns the total tax
-    per_order_fees_total = calculator.send(:per_order_enterprise_fee_applicators_for, order)
+    per_order_fees_total = calculator.per_order_enterprise_fee_applicators_for(order)
       .select { |applicator| applicator.enterprise_fee.tax_category == rate.tax_category }
       .sum { |applicator| applicator.enterprise_fee.compute_amount(order) }
 

app/models/spree/preferences/file_configuration.rb

@@ -15,7 +15,7 @@ def self.preference(name, type, *args)
 
     def get_preference(key)
       if !has_preference?(key) && has_attachment?(key)
-        send key
+        public_send key
       else
         super key
       end

app/models/subscription.rb

@@ -51,7 +51,7 @@ def paused?
   def state
     # NOTE: the order is important here
     %w(canceled paused pending ended).each do |state|
-      return state if send("#{state}?")
+      return state if __send__("#{state}?")
     end
     "active"
   end

app/serializers/api/admin/enterprise_fee_serializer.rb

@@ -15,7 +15,7 @@ def calculator_settings
 
     result = nil
 
-    options[:controller].send(:with_format, :html) do
+    options[:controller].__send__(:with_format, :html) do
       result = options[:controller].render_to_string :partial => 'admin/enterprise_fees/calculator_settings', :locals => {:enterprise_fee => object}
     end
 

app/services/order_syncer.rb

@@ -83,7 +83,7 @@ def relevant_address_attrs
 
   def addresses_match?(order_address, subscription_address)
     relevant_address_attrs.all? do |attr|
-      order_address[attr] == subscription_address.send("#{attr}_was") ||
+      order_address[attr] == subscription_address.public_send("#{attr}_was") ||
         order_address[attr] == subscription_address[attr]
     end
   end
@@ -101,7 +101,7 @@ def ship_address_updatable?(order)
   # address on the order matches the shop's address
   def force_ship_address_required?(order)
     return false unless shipping_method.require_ship_address?
-    distributor_address = order.send(:address_from_distributor)
+    distributor_address = order.__send__(:address_from_distributor)
     relevant_address_attrs.all? do |attr|
       order.ship_address[attr] == distributor_address[attr]
     end

lib/discourse/single_sign_on.rb

@@ -42,7 +42,7 @@ def self.parse(payload, sso_secret = nil)
         if BOOLS.include? k
           val = ["true", "false"].include?(val) ? val == "true" : nil
         end
-        sso.send("#{k}=", val)
+        sso.public_send("#{k}=", val)
       end
 
       decoded_hash.each do |k,v|
@@ -87,9 +87,9 @@ def payload
     def unsigned_payload
       payload = {}
       ACCESSORS.each do |k|
-       next if (val = send k) == nil
+        next if (val = public_send k) == nil
 
-       payload[k] = val
+        payload[k] = val
       end
 
       if @custom_fields

lib/open_food_network/address_finder.rb

@@ -12,7 +12,7 @@ def initialize(*args)
       args.each do |arg|
         type = types[arg.class]
         next unless type
-        send("#{type}=", arg)
+        public_send("#{type}=", arg)
       end
     end
 
@@ -24,16 +24,6 @@ def ship_address
       customer_preferred_ship_address || user_preferred_ship_address || fallback_ship_address
     end
 
-    private
-
-    def types
-      {
-        String      => "email",
-        Customer    => "customer",
-        Spree::User => "user"
-      }
-    end
-
     def email=(arg)
       @email ||= arg
     end
@@ -46,6 +36,16 @@ def user=(arg)
       @user ||= arg
     end
 
+    private
+
+    def types
+      {
+        String      => "email",
+        Customer    => "customer",
+        Spree::User => "user"
+      }
+    end
+
     def customer_preferred_bill_address
       customer.andand.bill_address
     end