-
-
Notifications
You must be signed in to change notification settings - Fork 729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Cookies] Updated cookies policy page text #2613
[Cookies] Updated cookies policy page text #2613
Conversation
Maybe multiple commits on policy_page view would have been better... but it should be straight forward to review anyway. |
ee01736
to
7e951bd
Compare
…dates to the page text, migrated translations to ruby translations and extracted repeated partial from cookies policy page view
7e951bd
to
02b968b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@myriamboure what do you think of the proposed solution? |
yes it's good it's exactly what I put in the template ;-) let's move to test ready! |
I staged this PR here: https://staging.openfoodfrance.org/ |
Testing notes: https://docs.google.com/document/d/1QzbpB9sU1bN0Y0x7_4mh49xOZJ7_Sic-C6a5ZAnmcew/edit# @luisramos0 the last sentence on the cookie policy page is not translate, but I checked in transifex and the translation is there, https://www.transifex.com/open-food-foundation/open-food-network/translate/#fr/enyml/150924320?q=text%3A'be+aware' any idea why? All the other strings are translated so it doesn't see normal... same in backoffice the back office configuration menu are well translated in Transifex and not on the staging. Is it something we should be worried about? I did the translation quite some time ago, so that sounds strange that they are not applied on staging today, and especially as most of them are. |
Hey @myriamboure thanks for testing! I had the same issue locally. I run the transifex script locally and I get those missing translations. So, the fix for the problem is to run the tx script to download translations. So, it should be fine. |
@luisramos0 all translations are saved in Transifex. So anyway, let's merge and we will be careful when we deploy to test if those translations are well integrated. We have lost some translations on other pages recently, so I think there are still issues with translations but they are not connected to that PR. |
Also migrated translations to ruby translations and extracted repeated partial from cookies policy page view.
What? Why?
Closes #2601
See issue.
What should we test?
The policy page content should be retested including the backoffice configurations to display/hide the GA/matomo parts.
Must be tested on mobile as well.
Release notes
Changelog Category: Fixed
Cookies policy page with better UX and updated text.