Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cookies] Updated cookies policy page text #2613

Merged

Conversation

luisramos0
Copy link
Contributor

Also migrated translations to ruby translations and extracted repeated partial from cookies policy page view.

What? Why?

Closes #2601

See issue.

What should we test?

The policy page content should be retested including the backoffice configurations to display/hide the GA/matomo parts.
Must be tested on mobile as well.

Release notes

Changelog Category: Fixed

Cookies policy page with better UX and updated text.

@luisramos0
Copy link
Contributor Author

luisramos0 commented Aug 29, 2018

Maybe multiple commits on policy_page view would have been better... but it should be straight forward to review anyway.

@luisramos0 luisramos0 force-pushed the cookies_better_policy_page branch from ee01736 to 7e951bd Compare August 29, 2018 22:51
@luisramos0 luisramos0 self-assigned this Aug 29, 2018
@luisramos0
Copy link
Contributor Author

This is how the table looks like now. I think it's much better.

screen shot 2018-08-29 at 23 55 45

screen shot 2018-08-29 at 23 54 10

…dates to the page text, migrated translations to ruby translations and extracted repeated partial from cookies policy page view
@luisramos0 luisramos0 force-pushed the cookies_better_policy_page branch from 7e951bd to 02b968b Compare August 29, 2018 23:27
Copy link
Member

@mkllnk mkllnk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sigmundpetersen
Copy link
Contributor

@myriamboure what do you think of the proposed solution?

@myriamboure
Copy link
Contributor

yes it's good it's exactly what I put in the template ;-) let's move to test ready!

@luisramos0
Copy link
Contributor Author

I staged this PR here: https://staging.openfoodfrance.org/

@myriamboure myriamboure self-assigned this Aug 31, 2018
@myriamboure
Copy link
Contributor

Testing notes: https://docs.google.com/document/d/1QzbpB9sU1bN0Y0x7_4mh49xOZJ7_Sic-C6a5ZAnmcew/edit#

@luisramos0 the last sentence on the cookie policy page is not translate, but I checked in transifex and the translation is there, https://www.transifex.com/open-food-foundation/open-food-network/translate/#fr/enyml/150924320?q=text%3A'be+aware' any idea why? All the other strings are translated so it doesn't see normal... same in backoffice the back office configuration menu are well translated in Transifex and not on the staging.
Those are not strings affected by this PR, strings affected are not translated but that's normal.

Is it something we should be worried about? I did the translation quite some time ago, so that sounds strange that they are not applied on staging today, and especially as most of them are.

@luisramos0
Copy link
Contributor Author

Hey @myriamboure thanks for testing!

I had the same issue locally. I run the transifex script locally and I get those missing translations. So, the fix for the problem is to run the tx script to download translations. So, it should be fine.
But In transifex's history I see you translated everything in the same day (11 days ago). And the last TX update was 10 days ago.
I dont understand why only some entries are left behind... except if you left some of the entries unreviewed in tx?
Anyway, the solution is always to update translations (run transifex script).
So, I think this is ready to go.

@luisramos0 luisramos0 changed the title Updated cookies policy page text [Cookies] Updated cookies policy page text Sep 2, 2018
@myriamboure
Copy link
Contributor

@luisramos0 all translations are saved in Transifex. So anyway, let's merge and we will be careful when we deploy to test if those translations are well integrated. We have lost some translations on other pages recently, so I think there are still issues with translations but they are not connected to that PR.
So let's merge, ready to go.

@mkllnk mkllnk merged commit 3fadd06 into openfoodfoundation:master Sep 3, 2018
@luisramos0 luisramos0 deleted the cookies_better_policy_page branch September 3, 2018 09:13
@luisramos0 luisramos0 added the pr-staged-fr staging.coopcircuits.fr label Sep 3, 2018
@sigmundpetersen sigmundpetersen removed the pr-staged-fr staging.coopcircuits.fr label Sep 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants