Spree 2 Upgrade - MailMethod - Fix "undefined mail method" error in specs #2588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luisramos0
changed the title
|
@luisramos0 please connect your PR's to issues :) |
mkllnk
requested changes
Aug 27, 2018
spec/models/order_cycle_spec.rb
Outdated
| end | ||
| before { order5.cancel } | ||
|
|
||
| it "only returns items from non-cancelled orders in the OC, placed by the user at the shop" do | ||
| items = oc.items_bought_by_user(user, shop) | ||
| items.sort_by!(&:id) |
There was a problem hiding this comment.
This seems completely unrelated to the task. A separate commit could have been good. And did you know about match_array?
There was a problem hiding this comment.
ok, moved this into a separate commit.
also used match_array instead, thanks, I didnt know it.
luisramos0
force-pushed
the
spree2_mail_method_specs
branch
from
c4c48aa to
082f9e4
Compare
mkllnk
approved these changes
Aug 27, 2018
sauloperez
approved these changes
Aug 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
Closes #2020
Doing exactly what's described in #2020.
What should we test?
All these specs should now have progressed to green or other errors as described below.
Tests not verifiable right now as tests fail with other errors:
Tests with new errors:
- other error related to email expectations
- other unrelated error
- other error related to email expectations
- other error related to email expectations
Green tests:
- green after PR Spree 2 Upgrade - MailMethod - Fixed bug on order_mailer_decorator (only visible in spree 2) #2587 and PR Spree2 - Bulk line items controller spec fix #2574
- green - I had to add a array sort in this spec expectation
- green
- green, just removed MailMethod call (this call is no longer needed)
- green, just removed MailMethod call
How is this related to the Spree upgrade?
This is part of getting the spree2 branch build to green.
Dependencies
This is related to PR #2587 and PR #2574 but can go first.