Disable rubocop cop "Rails/ActiveRecordAliases" #2517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The methods :update! and :update (to replace :update_attributes! and :update_attributes) were not added until Rails 4. See this for more information: https://www.rubydoc.info/gems/rubocop/RuboCop/Cop/Rails/ActiveRecordAliases
kristinalim
force-pushed
the
cleanup-disable_rubocop_cop_rails_activerecordaliases
branch
from
a748fa5 to
d77a943
Compare
mkllnk
approved these changes
Aug 6, 2018
kristinalim
deleted the
cleanup-disable_rubocop_cop_rails_activerecordaliases
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
In #2512,
rubocopcomplained that the code usesupdate_attributes!instead ofupdate!. But the latter is not yet available in the Rails version that we are using.See this for more information about the cop.
The cop documentation shows that these are the only methods it warns about:
Release notes
Changelog Category: Fixed
How is this related to the Spree upgrade?
If the Spree upgrade includes a major upgrade of Rails, we should enable the cop again.